Bug 67813 - -[WKView attributedSubstringForProposedRange:actualRange:] doesn't update actualRange when it's out of bounds
Summary: -[WKView attributedSubstringForProposedRange:actualRange:] doesn't update act...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks: 61889
  Show dependency treegraph
 
Reported: 2011-09-08 16:00 PDT by Alexey Proskuryakov
Modified: 2011-11-30 00:11 PST (History)
1 user (show)

See Also:


Attachments
proposed fix (2.17 KB, patch)
2011-09-08 16:02 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-09-08 16:00:46 PDT
WebKit currently attempts to send a range as large as the client requested, not trying to make it shorter for performance. But we have to shorten it if the length is out of bounds, and need to update actualRange accordingly.
Comment 1 Alexey Proskuryakov 2011-09-08 16:02:23 PDT
Created attachment 106807 [details]
proposed fix
Comment 2 WebKit Review Bot 2011-11-29 21:15:28 PST
Comment on attachment 106807 [details]
proposed fix

Rejecting attachment 106807 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
force --reset --delete_unversioned_trees'
No such file or directory at /mnt/git/webkit-commit-queue/Tools/Scripts/webkitdirs.pm line 2020.

Failed to run "['Tools/Scripts/build-webkit', '--release', '--chromium', '--update-chromium']" exit_code: 2
3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 109.
Re-trying 'depot_tools/gclient sync --force --reset --delete_unversioned_trees'
No such file or directory at /mnt/git/webkit-commit-queue/Tools/Scripts/webkitdirs.pm line 2020.

Full output: http://queues.webkit.org/results/10687049
Comment 3 Alexey Proskuryakov 2011-11-29 23:11:41 PST
Comment on attachment 106807 [details]
proposed fix

Error makes no sense, trying again.
Comment 4 WebKit Review Bot 2011-11-30 00:11:41 PST
Comment on attachment 106807 [details]
proposed fix

Clearing flags on attachment: 106807

Committed r101454: <http://trac.webkit.org/changeset/101454>
Comment 5 WebKit Review Bot 2011-11-30 00:11:46 PST
All reviewed patches have been landed.  Closing bug.