Bug 67813 – -[WKView attributedSubstringForProposedRange:actualRange:] doesn't update actualRange when it's out of bounds

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Alexey Proskuryakov]

WebKit currently attempts to send a range as large as the client requested, not trying to make it shorter for performance. But we have to shorten it if the length is out of bounds, and need to update actualRange accordingly.

[Alexey Proskuryakov]

Created attachment 106807 [details]
proposed fix

[WebKit Review Bot]

Comment on attachment 106807 [details]
proposed fix

Rejecting attachment 106807 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
force --reset --delete_unversioned_trees'
No such file or directory at /mnt/git/webkit-commit-queue/Tools/Scripts/webkitdirs.pm line 2020.

Failed to run "['Tools/Scripts/build-webkit', '--release', '--chromium', '--update-chromium']" exit_code: 2
3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 109.
Re-trying 'depot_tools/gclient sync --force --reset --delete_unversioned_trees'
No such file or directory at /mnt/git/webkit-commit-queue/Tools/Scripts/webkitdirs.pm line 2020.

Full output: http://queues.webkit.org/results/10687049

[Alexey Proskuryakov]

Comment on attachment 106807 [details]
proposed fix

Error makes no sense, trying again.

[WebKit Review Bot]

Comment on attachment 106807 [details]
proposed fix

Clearing flags on attachment: 106807

Committed r101454: <http://trac.webkit.org/changeset/101454>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.