Bug 67810 - Always zero-out m_sortedTextBoxesPosition to avoid unintialized read in TextIterator
Summary: Always zero-out m_sortedTextBoxesPosition to avoid unintialized read in TextI...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Abhishek Arya
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-08 15:15 PDT by Adam Klein
Modified: 2011-09-12 21:52 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.18 KB, patch)
2011-09-08 15:19 PDT, Adam Klein
no flags Details | Formatted Diff | Diff
Updated ChangeLog (2.21 KB, patch)
2011-09-08 15:28 PDT, Adam Klein
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Klein 2011-09-08 15:15:55 PDT
Always zero-out m_sortedTextBoxesPosition to avoid unintialized read in TextIterator
Comment 1 Adam Klein 2011-09-08 15:19:48 PDT
Created attachment 106800 [details]
Patch
Comment 2 Ryosuke Niwa 2011-09-08 15:22:06 PDT
You should mention that it was causing a valgrind failure.
Comment 3 Adam Klein 2011-09-08 15:28:18 PDT
Created attachment 106803 [details]
Updated ChangeLog
Comment 4 Adam Klein 2011-09-08 15:29:05 PDT
(In reply to comment #2)
> You should mention that it was causing a valgrind failure.

Added a mention of valgrind to the ChangeLog.
Comment 5 WebKit Review Bot 2011-09-08 18:13:56 PDT
Comment on attachment 106803 [details]
Updated ChangeLog

Clearing flags on attachment: 106803

Committed r94824: <http://trac.webkit.org/changeset/94824>
Comment 6 WebKit Review Bot 2011-09-08 18:14:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Abhishek Arya 2011-09-12 21:52:45 PDT
Forgot to read "The unitialized read
 11        could never have an impact:"