Bug 6778 - Crash if a node is removed from the DOM before being reparented due to residual style
Summary: Crash if a node is removed from the DOM before being reparented due to residu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 420+
Hardware: PC Linux
: P2 Normal
Assignee: Maciej Stachowiak
URL: http://www.hixie.ch/tests/adhoc/html/...
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-24 16:29 PST by Ian 'Hixie' Hickson
Modified: 2006-01-25 00:34 PST (History)
2 users (show)

See Also:


Attachments
a simple fix (1.59 KB, patch)
2006-01-24 17:27 PST, Maciej Stachowiak
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ian 'Hixie' Hickson 2006-01-24 16:29:09 PST
The immortal words:
<hyatt> i don't see why we would have any trouble with that
<hyatt> the parser can deal with elements getting yanked away by script
Comment 1 Maciej Stachowiak 2006-01-24 17:27:36 PST
Created attachment 5932 [details]
a simple fix

This fix will avoid the crash from trying to remove a node from a null parent, but in the case where the block has been detached by script, it will also skip reattaching it in its new location.
Comment 2 Darin Adler 2006-01-24 18:14:52 PST
Comment on attachment 5932 [details]
a simple fix

Needs test case and change log.
Comment 3 Dave Hyatt 2006-01-24 18:51:52 PST
Comment on attachment 5932 [details]
a simple fix

r=me, add a comment above the decl of blockStillInTree that explains what it is and why it is needed.