compiler/glslang_lex.cpp: In function ‘int yylex(YYSTYPE*, yyscan_t)’: compiler/glslang_lex.cpp:1693:5: error: ignoring return value of ‘size_t fwrite(const void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result [-Werror=unused-result] cc1plus: all warnings being treated as errors make[1]: *** [obj/release/glslang_lex.o] Error 1 make[1]: *** Waiting for unfinished jobs.... ../../../Source/WebCore/platform/graphics/TiledBackingStore.cpp: In member function ‘bool WebCore::TiledBackingStore::resizeEdgeTiles()’: ../../../Source/WebCore/platform/graphics/TiledBackingStore.cpp:343:13: error: variable ‘contentsRect’ set but not used [-Werror=unused-but-set-variable] cc1plus: all warnings being treated as errors glslang_lex.cpp needs an update, and the unused variable needs to be removed.
Created attachment 106729 [details] proposed fix
Attachment 106729 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ANGLE/ChangeLog', u'Sour..." exit_code: 1 Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:862: Extra space before ( in function call [whitespace/parens] [4] Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:862: Extra space before ) [whitespace/parens] [2] Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:862: yyget_column is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:864: Missing space after , [whitespace/comma] [3] Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:864: Extra space before ( in function call [whitespace/parens] [4] Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:864: Extra space before ) [whitespace/parens] [2] Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:864: yyset_column is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:864: column_no is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:916: Extra space after ( in function call [whitespace/parens] [4] Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:916: Missing space inside { }. [whitespace/braces] [5] Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:927: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 11 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 106729 [details] proposed fix r=me, but cq-, because commit queue doesn't like my name. :)
Just for the record glslang_lex.cpp is a pre-generated file, that is why the style-bot fails. (In reply to comment #2) > Attachment 106729 [details] did not pass style-queue:
Comment on attachment 106729 [details] proposed fix Clearing flags on attachment: 106729 Committed r94757: <http://trac.webkit.org/changeset/94757>
All reviewed patches have been landed. Closing bug.