When you run build-webkit script, you always get this warning 6 times. (Reading /home/oszi/WebKit/Source/WebKit/qt/Api/DerivedSources.pro) ---> HEADER == /home/oszi/WebKit/Source/WebKit/qt/Api/qwebframe.h WARNING: /home/oszi/WebKit/Source/WebKit/qt/Api/DerivedSources.pro:59: Unmatched parentheses are deprecated. WARNING: /home/oszi/WebKit/Source/WebKit/qt/Api/DerivedSources.pro:59: Unmatched parentheses are deprecated. ---> HEADER == /home/oszi/WebKit/Source/WebKit/qt/Api/qwebview.h WARNING: /home/oszi/WebKit/Source/WebKit/qt/Api/DerivedSources.pro:59: Unmatched parentheses are deprecated. WARNING: /home/oszi/WebKit/Source/WebKit/qt/Api/DerivedSources.pro:59: Unmatched parentheses are deprecated. ---> HEADER == /home/oszi/WebKit/Source/WebKit/qt/Api/qwebpluginfactory.h WARNING: /home/oszi/WebKit/Source/WebKit/qt/Api/DerivedSources.pro:59: Unmatched parentheses are deprecated. WARNING: /home/oszi/WebKit/Source/WebKit/qt/Api/DerivedSources.pro:59: Unmatched parentheses are deprecated. It might be fixed in the pro file or it might be a qmake bug.
This is caused by reading header files that contain function declarations that spread over multiple lines using the cat() call in .pro files. The easiest workaround would be to write function declarations in the affected files always on a single line. For a proper fix we would need to add functionality to qmake.
Created attachment 107035 [details] proposed workaround
Attachment 107035 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/Api/qwebframe.h', u'Sourc..." exit_code: 1 Source/WebKit/qt/Api/qwebview.h:64: The parameter name "request" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/qt/Api/qwebview.h:64: The parameter name "operation" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/qt/Api/qwebframe.h:127: The parameter name "request" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/qt/Api/qwebframe.h:127: The parameter name "operation" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 107035 [details] proposed workaround The Qt API has a different style than WebKit, so the warnings of the style checker can be ignored.
Comment on attachment 107035 [details] proposed workaround Rejecting attachment 107035 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: e2f4da75c0181c0dbc27b418a51380b53ed09346 r94953 = e822bceff99dae95dd27fe318b2aebd379604f74 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9634946
Landed in http://trac.webkit.org/changeset/94968
(In reply to comment #1) > This is caused by reading header files that contain function declarations that spread over multiple lines using the cat() call in .pro files. > The easiest workaround would be to write function declarations in the affected files always on a single line. > For a proper fix we would need to add functionality to qmake. Thanks, it works.