Bug 67760 - layout test media/media-document-audio-repaint.html needs rebaseline
Summary: layout test media/media-document-audio-repaint.html needs rebaseline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-07 21:08 PDT by imasaki
Modified: 2012-01-10 23:21 PST (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description imasaki 2011-09-07 21:08:11 PDT
Right now layout test media/media-document-audio-repaint.html (fails on Chromium GPU as you see below.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20GPU%20Mesa%20-%20chromium.org&tests=media%2Fmedia-document-audio-repaint.html

http://trac.webkit.org/browser/trunk/LayoutTests/media/media-document-audio-repaint.html#L8 shows it uses layoutTestController.display().

As for now. we will skip the test on GPU. However, it would be nice if this is implemented. 

Please let me know if you need more information.
Comment 1 Andrew Scherkus 2011-09-08 10:09:47 PDT
Adding jamesr/kbr to see if they have any ideas on implementing said DRT function

I believe the common use case is to get DRT to paint over the entire screen with semi-transparent gray then trigger something that will cause a repaint, presumably testing that we're not painting too much.

I'm not sure if this makes sense for GPU compositing or what the equivalent test would be.
Comment 2 James Robinson 2011-09-08 10:39:07 PDT
LayoutTestController.display() is (obviously) implemented, we have a ton of tests that depend on it.  It doesn't have the same incremental repaint behavior as the software path because we don't do incremental composites, we always composite the full screen.

You should NOT skip the test unless it crashes.  Add the correct expectations.
Comment 3 Andrew Scherkus 2011-09-08 10:48:48 PDT
Thanks for the explanation!

imasaki: want to double check our test expectations? the pixel result should look like the CPU version, except have a white background instead of the gray
Comment 4 imasaki 2011-09-14 12:24:57 PDT
I double checked and the pixel result good.

Rebaseline committed:
https://bugs.webkit.org/attachment.cgi?id=105420&action=review
Comment 5 imasaki 2011-09-28 09:49:22 PDT
sorry, my bad. The expected result does not look right. I will be working on rebaseline.
Comment 6 imasaki 2011-11-01 16:53:24 PDT
I am working on rebaseline for GPU
Comment 7 imasaki 2011-11-01 20:38:25 PDT
Rebaselines are committed. https://bugs.webkit.org/show_bug.cgi?id=67760
Comment 9 Dale Curtis 2012-01-06 11:21:51 PST
I'm rebaselining this test as a result of another change, https://bugs.webkit.org/show_bug.cgi?id=75505 . I suspect this can be closed once that one goes in.
Comment 10 Dale Curtis 2012-01-06 16:27:02 PST
This can now be closed.