Bug 67751 – Rebaseline for bug 65583 (path based border radius drawing on skia) part 2

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ben Wells]

Rebaseline for bug 65583 (path based border radius drawing on skia) part 2

[Ben Wells]

Created attachment 106680 [details]
Patch

[Ben Wells]

Due to bug 67628, some images can't be seen in the formatted diff. I am attaching all the new images separately.

[Ben Wells]

Created attachment 106682 [details]
LayoutTests/platform/chromium-linux/fast/forms/basic-selects-expected.png

[Ben Wells]

Created attachment 106683 [details]
LayoutTests/platform/chromium-linux/fast/inline/inline-borders-with-bidi-override-expected.png

[Ben Wells]

Created attachment 106684 [details]
LayoutTests/platform/chromium-linux/fast/overflow/border-radius-clipping-expected.png

[Ben Wells]

Created attachment 106685 [details]
LayoutTests/platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.png

[WebKit Review Bot]

Attachment 106680 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

ERROR: FAILURES FOR <lucid, x86_64, release, cpu>
ERROR: Line:3430 Path does not exist. compositing/color-matching/image-makering.html
LayoutTests/platform/chromium/test_expectations.txt:3430:  Path does not exist. compositing/color-matching/image-makering.html  [test/expectations] [2]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ben Wells]

Created attachment 106686 [details]
LayoutTests/platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.png

[Ben Wells]

Created attachment 106687 [details]
LayoutTests/platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.png

[Ben Wells]

Created attachment 106688 [details]
LayoutTests/platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png

[Ben Wells]

Created attachment 106689 [details]
LayoutTests/platform/chromium-linux/fast/transforms/shadows-expected.png

[Ben Wells]

Created attachment 106690 [details]
LayoutTests/platform/chromium-win/fast/forms/basic-selects-expected.png

[Ben Wells]

Created attachment 106691 [details]
LayoutTests/platform/chromium-win/fast/repaint/border-radius-repaint-expected.png

[Ben Wells]

Style error is in a part of the file I haven't changed.

[Kenneth Russell]

Comment on attachment 106680 [details]
Patch

Where the before-and-after images show up in the pretty diff, the new baselines look good. It was a little difficult to reason about the separately attached ones. Please press ahead with https://bugs.webkit.org/show_bug.cgi?id=67628 . Thanks. r=me

[WebKit Review Bot]

Comment on attachment 106680 [details]
Patch

Clearing flags on attachment: 106680

Committed r94782: <http://trac.webkit.org/changeset/94782>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.