Bug 67749 - AudioBufferSourceNode must validate AudioBuffer in .buffer attribute setter
Summary: AudioBufferSourceNode must validate AudioBuffer in .buffer attribute setter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-07 17:28 PDT by Chris Rogers
Modified: 2011-09-09 15:14 PDT (History)
1 user (show)

See Also:

Attachments
Patch (12.52 KB, patch)
2011-09-07 18:32 PDT, Chris Rogers 		kbr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2011-09-07 17:28:40 PDT 
AudioBufferSourceNode must validate AudioBuffer in .buffer attribute setter
Comment 1 Chris Rogers 2011-09-07 18:32:26 PDT 
Created attachment 106677 [details]
Patch
Comment 2 Kenneth Russell 2011-09-07 20:30:56 PDT 
Comment on attachment 106677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=106677&action=review

Looks fine; one minor comment.

> Source/WebCore/webaudio/AudioBufferSourceNode.cpp:341
> +            return false; // the current implementation handles only mono and stereo playback

Do you want to add a FIXME here?
Comment 3 Chris Rogers 2011-09-09 15:14:39 PDT 
Committed r94878: <http://trac.webkit.org/changeset/94878>