Bug 67747 - Add a script to create a monolithic script-test
Summary: Add a script to create a monolithic script-test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks: 66357
  Show dependency tree / graph
 
Reported: 2011-09-07 16:44 PDT by Alexey Proskuryakov
Modified: 2011-09-09 21:01 PDT (History)
4 users (show)

See Also:

Attachments
proposed patch (4.90 KB, patch)
2011-09-07 16:45 PDT, Alexey Proskuryakov 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-09-07 16:44:46 PDT 
As I'm recommending against using split tests, Maciej raised a concern that it's difficult to create monolithic tests manually.

Indeed, you need to find an existing script test, copy boilerplate, and fix the number of ".." path components.
Comment 1 Alexey Proskuryakov 2011-09-07 16:45:54 PDT 
Created attachment 106673 [details]
proposed patch
Comment 2 Darin Adler 2011-09-07 17:58:50 PDT 
Comment on attachment 106673 [details]
proposed patch

Seems like a good start.
Comment 3 Alexey Proskuryakov 2011-09-09 21:01:51 PDT 
There was some disagreement on mailing list whether this is going to be useful. The discussion has dried out, and I guess that the only way to know that for sure is to land and try.

Committed <http://trac.webkit.org/changeset/94899>.