* STEPS TO REPRODUCE 1. http://public.yahoo.com/kloots/menu-button-test.html * RESULTS First two buttons behave as expected: "Options popup button" Second two buttons do not: "Options button" Expected "Options popup button" WebKit is exposing the first set as: AXRole: AXPopupButton AXHasPopup: YES WebKit is exposing the second set as: AXRole: AXButton AXHasPopup: YES
rdar://9244123
Created attachment 106661 [details] patch In the patch, I remove this block if (node && node->hasTagName(buttonTag)) because it's duplicated only a few lines above that. This is removed - if (cssBox && cssBox->isRenderButton()) - return toRenderButton(m_renderer)->text(); because it causes the text to be duplicated as the title.
Comment on attachment 106661 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=106661&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1157 > if (isWebArea()) { This is where the AXValue of a button can be duplicated in the AXTitle if there's a value attribute used in the button
Comment on attachment 106661 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=106661&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3107 > + return (ariaHasPopup()) ? PopUpButtonRole : ButtonRole; Extra parentheses here that are not needed.
http://trac.webkit.org/changeset/98962