Bug 67740 - Fixed Hit testing on Framesets when Frameset is transformed
Summary: Fixed Hit testing on Framesets when Frameset is transformed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fady Samuel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-07 15:23 PDT by Fady Samuel
Modified: 2011-09-29 21:43 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.64 KB, patch)
2011-09-07 15:24 PDT, Fady Samuel
no flags Details | Formatted Diff | Diff
Patch (6.10 KB, patch)
2011-09-29 16:21 PDT, Fady Samuel
no flags Details | Formatted Diff | Diff
Patch (9.56 KB, patch)
2011-09-29 20:06 PDT, Fady Samuel
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fady Samuel 2011-09-07 15:23:55 PDT
Fixed Hit testing on Framesets when Frameset is transformed
Comment 1 Fady Samuel 2011-09-07 15:24:58 PDT
Created attachment 106657 [details]
Patch
Comment 2 Fady Samuel 2011-09-07 15:25:55 PDT
I'm not sure how to write a layout test for this. I'll gladly welcome suggestions if possible...
Comment 3 Simon Fraser (smfr) 2011-09-07 16:05:37 PDT
Comment on attachment 106657 [details]
Patch

Should be able to test with document.elementFromPoint().
Comment 4 Fady Samuel 2011-09-29 16:21:41 PDT
Created attachment 109215 [details]
Patch
Comment 5 Simon Fraser (smfr) 2011-09-29 18:08:00 PDT
Comment on attachment 109215 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109215&action=review

Code changes look ok, but r- for one more test.

> LayoutTests/fast/frames/frame-set-scaling-hit.html:15
> +        function init() {
> +            if (!window.eventSender)
> +                return;
> +            var leftPanelWidth = window.innerWidth / 8;
> +            eventSender.scalePageBy(0.5, 0, 0);
> +            eventSender.mouseMoveTo(leftPanelWidth, window.innerHeight / 4);
> +            eventSender.mouseDown();
> +            eventSender.mouseMoveTo(2 * leftPanelWidth, window.innerHeight / 4);
> +            eventSender.mouseUp();
> +        }

Please add a comment to say that this is trying to resize the frames. It wasn't obvious.

I'd like to see a test that has a rotation too.
Comment 6 Fady Samuel 2011-09-29 20:06:14 PDT
Created attachment 109246 [details]
Patch
Comment 7 WebKit Review Bot 2011-09-29 21:43:48 PDT
Comment on attachment 109246 [details]
Patch

Clearing flags on attachment: 109246

Committed r96385: <http://trac.webkit.org/changeset/96385>
Comment 8 WebKit Review Bot 2011-09-29 21:43:52 PDT
All reviewed patches have been landed.  Closing bug.