RESOLVED FIXED Bug 67740
Fixed Hit testing on Framesets when Frameset is transformed
https://bugs.webkit.org/show_bug.cgi?id=67740
Summary Fixed Hit testing on Framesets when Frameset is transformed
Fady Samuel
Reported 2011-09-07 15:23:55 PDT
Fixed Hit testing on Framesets when Frameset is transformed
Attachments
Patch (2.64 KB, patch)
2011-09-07 15:24 PDT, Fady Samuel
no flags
Patch (6.10 KB, patch)
2011-09-29 16:21 PDT, Fady Samuel
no flags
Patch (9.56 KB, patch)
2011-09-29 20:06 PDT, Fady Samuel
no flags
Fady Samuel
Comment 1 2011-09-07 15:24:58 PDT
Fady Samuel
Comment 2 2011-09-07 15:25:55 PDT
I'm not sure how to write a layout test for this. I'll gladly welcome suggestions if possible...
Simon Fraser (smfr)
Comment 3 2011-09-07 16:05:37 PDT
Comment on attachment 106657 [details] Patch Should be able to test with document.elementFromPoint().
Fady Samuel
Comment 4 2011-09-29 16:21:41 PDT
Simon Fraser (smfr)
Comment 5 2011-09-29 18:08:00 PDT
Comment on attachment 109215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109215&action=review Code changes look ok, but r- for one more test. > LayoutTests/fast/frames/frame-set-scaling-hit.html:15 > + function init() { > + if (!window.eventSender) > + return; > + var leftPanelWidth = window.innerWidth / 8; > + eventSender.scalePageBy(0.5, 0, 0); > + eventSender.mouseMoveTo(leftPanelWidth, window.innerHeight / 4); > + eventSender.mouseDown(); > + eventSender.mouseMoveTo(2 * leftPanelWidth, window.innerHeight / 4); > + eventSender.mouseUp(); > + } Please add a comment to say that this is trying to resize the frames. It wasn't obvious. I'd like to see a test that has a rotation too.
Fady Samuel
Comment 6 2011-09-29 20:06:14 PDT
WebKit Review Bot
Comment 7 2011-09-29 21:43:48 PDT
Comment on attachment 109246 [details] Patch Clearing flags on attachment: 109246 Committed r96385: <http://trac.webkit.org/changeset/96385>
WebKit Review Bot
Comment 8 2011-09-29 21:43:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.