RESOLVED FIXED 67739
adjustRectForColumns is slow when a huge # of columns are involved 
https://bugs.webkit.org/show_bug.cgi?id=67739
Summary adjustRectForColumns is slow when a huge # of columns are involved
Dave Hyatt
Reported 2011-09-07 15:14:04 PDT
adjustRectForColumns is slow when a huge # of columns are involved, since it always loops over every single column regardless of how tiny the repaint rect is. This is a stupid thing to do, since intermediate columns between your beginning and end column always fully repaint anyway.
Attachments
Patch (3.51 KB, patch)
2011-09-07 15:31 PDT, Dave Hyatt 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2011-09-07 15:31:01 PDT
Created attachment 106659 [details] Patch
WebKit Review Bot
Comment 2 2011-09-07 15:33:55 PDT
Attachment 106659 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/rendering/RenderBlock.cpp:4622: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3 2011-09-07 15:59:13 PDT
Comment on attachment 106659 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106659&action=review >> Source/WebCore/rendering/RenderBlock.cpp:4622 >> + if (colHeight == 0) > > Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] That’s right.
Dave Hyatt
Comment 4 2011-09-07 17:51:15 PDT
Fixed in r94737.
Ryosuke Niwa
Comment 6 2011-09-07 18:40:21 PDT
Fixed Windows build in http://trac.webkit.org/changeset/94739 and http://trac.webkit.org/changeset/94740.
Note You need to log in before you can comment on or make changes to this bug.