Bug 67730 - Support the hyphenate-limit-lines property
Summary: Support the hyphenate-limit-lines property
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords: InRadar
Depends on:
Blocks: 67768
  Show dependency treegraph
 
Reported: 2011-09-07 13:30 PDT by mitz
Modified: 2011-09-08 09:04 PDT (History)
3 users (show)

See Also:


Attachments
Avoid runs of consecutive hyphenated lines longer than the limit (143.41 KB, patch)
2011-09-07 13:44 PDT, mitz
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 mitz 2011-09-07 13:44:46 PDT
Created attachment 106629 [details]
Avoid runs of consecutive hyphenated lines longer than the limit

This first cut simply prevents hyphenation of a line if the limit has been reached. This can be refined to restrict hyphenation even before reaching the limit.
Comment 2 Dave Hyatt 2011-09-07 13:53:43 PDT
Comment on attachment 106629 [details]
Avoid runs of consecutive hyphenated lines longer than the limit

r=me
Comment 3 mitz 2011-09-07 13:59:16 PDT
Landed in <http://trac.webkit.org/r94710>.
Comment 4 Ryosuke Niwa 2011-09-07 16:26:20 PDT
Rebaseline: http://trac.webkit.org/changeset/94726.
Comment 5 mitz 2011-09-07 16:37:13 PDT
Thank you!
Comment 6 Ryosuke Niwa 2011-09-07 19:12:46 PDT
The test added by this patch is failing on Snow Leopard.
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r94737%20(32908)/fast/text/hyphenate-limit-lines-pretty-diff.html

Should we just rebaseline or not?
Comment 7 mitz 2011-09-07 19:20:19 PDT
Those results look wrong.
Comment 8 Ryosuke Niwa 2011-09-07 19:22:51 PDT
(In reply to comment #7)
> Those results look wrong.

Can we file a bug and skip it temporarily on the bot?
Comment 9 mitz 2011-09-07 20:35:10 PDT
Unfortunately, hyphenation on Snow Leopard gets confused by trailing punctuation. I am going to commit the current results as expected for Snow Leopard and earlier.
Comment 10 mitz 2011-09-07 20:39:21 PDT
Snow Leopard results added in <http://trac.webkit.org/r94743>.
Comment 11 Simon Fraser (smfr) 2011-09-08 09:04:49 PDT
(In reply to comment #9)
> Unfortunately, hyphenation on Snow Leopard gets confused by trailing punctuation.
Should a new bug be filed to cover this?