Bug 67730 – Support the hyphenate-limit-lines property

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

<rdar://problem/8881922>

<http://dev.w3.org/cvsweb/~checkout~/csswg/css3-text/Overview.html?rev=1.181;content-type=text%2Fhtml#hyphenate-line-limits>

Created attachment 106629 [details]
Avoid runs of consecutive hyphenated lines longer than the limit

This first cut simply prevents hyphenation of a line if the limit has been reached. This can be refined to restrict hyphenation even before reaching the limit.

[Dave Hyatt]

Comment on attachment 106629 [details]
Avoid runs of consecutive hyphenated lines longer than the limit

r=me

Landed in <http://trac.webkit.org/r94710>.

[Ryosuke Niwa]

Rebaseline: http://trac.webkit.org/changeset/94726.

Thank you!

[Ryosuke Niwa]

The test added by this patch is failing on Snow Leopard.
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r94737%20(32908)/fast/text/hyphenate-limit-lines-pretty-diff.html

Should we just rebaseline or not?

Those results look wrong.

[Ryosuke Niwa]

(In reply to comment #7)
> Those results look wrong.

Can we file a bug and skip it temporarily on the bot?

Unfortunately, hyphenation on Snow Leopard gets confused by trailing punctuation. I am going to commit the current results as expected for Snow Leopard and earlier.

Snow Leopard results added in <http://trac.webkit.org/r94743>.

[Simon Fraser (smfr)]

(In reply to comment #9)
> Unfortunately, hyphenation on Snow Leopard gets confused by trailing punctuation.
Should a new bug be filed to cover this?