Bug 67718 - <style scoped>: Add 'scoped' attribute
Summary: <style scoped>: Add 'scoped' attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Roland Steiner
URL:
Keywords:
Depends on: 67796 67811
Blocks: 49142 67790
  Show dependency treegraph
 
Reported: 2011-09-07 11:08 PDT by Roland Steiner
Modified: 2011-12-05 03:48 PST (History)
11 users (show)

See Also:


Attachments
Patch (12.17 KB, patch)
2011-09-08 10:56 PDT, Roland Steiner
no flags Details | Formatted Diff | Diff
patch with flag (16.96 KB, patch)
2011-12-04 22:51 PST, Roland Steiner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Steiner 2011-09-07 11:08:41 PDT
As part of the larger <style scoped> implementation, implement the necessary changes to the DOM and HTML classes.
Comment 1 Roland Steiner 2011-09-08 10:56:43 PDT
Created attachment 106763 [details]
Patch

The patch adds the 'scoped' attribute to the HTMLStyleElement IDL and HTMLAttributeNames.in, and tests setting and re-setting the attribute in various circumstances.
Comment 2 Roland Steiner 2011-09-08 12:55:39 PDT
Committed r94784: <http://trac.webkit.org/changeset/94784>
Comment 3 Roland Steiner 2011-09-08 13:36:32 PDT
Rolled out in r106777 in order to allow for more discussion
Comment 4 WebKit Review Bot 2011-09-08 15:16:41 PDT
Comment on attachment 106763 [details]
Patch

Clearing flags on attachment: 106763

Committed r94809: <http://trac.webkit.org/changeset/94809>
Comment 5 WebKit Review Bot 2011-09-08 15:16:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Roland Steiner 2011-09-08 15:44:25 PDT
Reverted r94809 for reason:

commit _still_ premature, despite CQ eagerness

Committed r94813: <http://trac.webkit.org/changeset/94813>
Comment 7 Dimitri Glazkov (Google) 2011-11-18 07:33:21 PST
Do we need an ENABLE flag for this, at least while the implementation is incomplete?
Comment 8 Roland Steiner 2011-11-20 22:04:24 PST
Opened a new bug https://bugs.webkit.org/show_bug.cgi?id=72848 for the ENABLE flag.
Comment 9 Roland Steiner 2011-11-21 00:41:22 PST
A question is, do we need to add the flag to code that handles the attribute/property, but has no outside side effects? I.e:

- attribute reflection code
- registration with parent element
- window.internals.numberOfScopedHTMLStyleChildren function
Comment 10 Dimitri Glazkov (Google) 2011-11-21 09:03:29 PST
(In reply to comment #9)
> A question is, do we need to add the flag to code that handles the attribute/property, but has no outside side effects? I.e:
> 
> - attribute reflection code
> - registration with parent element
> - window.internals.numberOfScopedHTMLStyleChildren function

Yes. One of the uses of the flag is to remove a feature in case it is unstable, and that wouldn't work if we only limited the flag to the author-visible effects.
Comment 11 Roland Steiner 2011-11-22 00:16:30 PST
(In reply to comment #10)
> Yes. One of the uses of the flag is to remove a feature in case it is unstable, and that wouldn't work if we only limited the flag to the author-visible effects.

In that case, how do I best handle the addition/changes to HTMLAttributeNames.in and HTMLStyleElement.idl?
Comment 12 Dimitri Glazkov (Google) 2011-11-22 09:35:42 PST
(In reply to comment #11)
> (In reply to comment #10)
> > Yes. One of the uses of the flag is to remove a feature in case it is unstable, and that wouldn't work if we only limited the flag to the author-visible effects.
> 
> In that case, how do I best handle the addition/changes to HTMLAttributeNames.in and HTMLStyleElement.idl?

1) Add item to HTMLAttributeNames.in
2) Add conditional attribute to HTMLStyleElement.idl

In other words, follow existing conventions.
Comment 13 Roland Steiner 2011-12-04 22:51:51 PST
Created attachment 117846 [details]
patch with flag

Same patch as before, with added ENABLE(STYLE_SCOPED) flag
Comment 14 WebKit Review Bot 2011-12-05 03:48:46 PST
Comment on attachment 117846 [details]
patch with flag

Clearing flags on attachment: 117846

Committed r101987: <http://trac.webkit.org/changeset/101987>
Comment 15 WebKit Review Bot 2011-12-05 03:48:55 PST
All reviewed patches have been landed.  Closing bug.