Bug 67711 – Web Inspector: [REGRESSION] Clear console shortcut Ctrl + L broken

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

This was regressed in r93769.

Patch to follow

[Alexander Pavlov (apavlov)]

Upstreaming http://code.google.com/p/chromium/issues/detail?id=95495

[Alexander Pavlov (apavlov)]

Created attachment 106590 [details]
[PATCH] Suggested fix

[Yury Semikhatsky]

Comment on attachment 106590 [details]
[PATCH] Suggested fix

View in context: https://bugs.webkit.org/attachment.cgi?id=106590&action=review

> Source/WebCore/inspector/front-end/ConsoleView.js:495
>          this._shortcuts[shortcutK.key].isMacOnly = true;

I'd suggest you get rid of the isMacOnly flag and set this handler only if current platform is Mac, this way you'll be able to share the handler.

[Alexander Pavlov (apavlov)]

(In reply to comment #3)
> (From update of attachment 106590 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=106590&action=review
> 
> > Source/WebCore/inspector/front-end/ConsoleView.js:495
> >          this._shortcuts[shortcutK.key].isMacOnly = true;
> 
> I'd suggest you get rid of the isMacOnly flag and set this handler only if current platform is Mac, this way you'll be able to share the handler.

Does it make sense to have the isMacOnly flag at all? Can't believe it's the only instance of its usage...

[Alexander Pavlov (apavlov)]

Created attachment 106712 [details]
[PATCH] Comments addressed

[Alexander Pavlov (apavlov)]

Committed r94758: <http://trac.webkit.org/changeset/94758>

[Pavel Feldman]

*** Bug 68907 has been marked as a duplicate of this bug. ***