Bug 67691 - Remove getUInt32 from JSCell
Summary: Remove getUInt32 from JSCell
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks: 67690
  Show dependency tree / graph
 
Reported: 2011-09-06 18:29 PDT by Mark Hahnenberg
Modified: 2011-09-09 04:58 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.64 KB, patch)
2011-09-06 19:30 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (3.57 KB, patch)
2011-09-07 10:53 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (3.57 KB, patch)
2011-09-07 13:24 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2011-09-06 18:29:52 PDT 
getUInt32 is no longer used in JSC.  We should remove it.
Comment 1 Mark Hahnenberg 2011-09-06 19:30:29 PDT 
Created attachment 106535 [details]
Patch
Comment 2 Mark Hahnenberg 2011-09-07 10:53:31 PDT 
Created attachment 106600 [details]
Patch
Comment 3 Mark Hahnenberg 2011-09-07 13:24:44 PDT 
Created attachment 106625 [details]
Patch
Comment 4 Oliver Hunt 2011-09-07 15:38:57 PDT 
Comment on attachment 106625 [details]
Patch

r=me assuming jsc-tests passes in 32-bit (run-javascriptcore-tests --32-bit)
Comment 5 Mark Hahnenberg 2011-09-07 15:43:35 PDT 
(In reply to comment #4)
> (From update of attachment 106625 [details])
> r=me assuming jsc-tests passes in 32-bit (run-javascriptcore-tests --32-bit)

No regressions that I can see.
Comment 6 Geoffrey Garen 2011-09-07 16:47:15 PDT 
Comment on attachment 106625 [details]
Patch

cq+, since mark is not yet a committer.
Comment 7 WebKit Review Bot 2011-09-08 11:41:00 PDT 
Comment on attachment 106625 [details]
Patch

Clearing flags on attachment: 106625

Committed r94774: <http://trac.webkit.org/changeset/94774>
Comment 8 WebKit Review Bot 2011-09-08 11:41:05 PDT 
All reviewed patches have been landed.  Closing bug.