Remove JSObjectWithGlobalObject
Created attachment 106528 [details] Patch
Attachment 106528 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackConstr..." exit_code: 1 Source/JavaScriptCore/runtime/MathObject.h:28: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/JavaScriptCore/runtime/RegExpObject.h:29: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 2 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.
r=me too, but you're going to need to update the windows project file, .def file, and other project files, I assume.
Created attachment 106530 [details] Patch
Attachment 106530 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackConstr..." exit_code: 1 Source/JavaScriptCore/runtime/MathObject.h:28: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/JavaScriptCore/runtime/RegExpObject.h:29: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 2 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.
Really, the qt bot is 20 builds behind? is it modeling itself after the mac-ews?
Created attachment 106599 [details] Patch
Attachment 106599 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackConstr..." exit_code: 1 Source/JavaScriptCore/runtime/MathObject.h:28: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/JavaScriptCore/runtime/RegExpObject.h:29: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 2 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 106599 [details] Patch r=me, assuming it builds
(In reply to comment #9) > (From update of attachment 106599 [details]) > r=me, assuming it builds I'm not making significant changes, just pounding this through the EWS bots
Created attachment 106611 [details] Patch
Attachment 106611 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackConstr..." exit_code: 1 Source/JavaScriptCore/runtime/MathObject.h:28: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/JavaScriptCore/runtime/RegExpObject.h:29: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 2 in 47 files If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r94701: <http://trac.webkit.org/changeset/94701>
Binding tests started to failing after this patch: http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20%28Tests%29/builds/2043 output: http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20%28Tests%29/builds/2043/steps/bindings-generation-tests/logs/stdio
There is Source/WebCore/ForwardingHeaders/runtime/JSObjectWithGlobalObject.h, yet. That file should be removed, right?