Bug 67688 - fast/forms/suggested-value-crash.html crashes on Windows
Summary: fast/forms/suggested-value-crash.html crashes on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-06 17:51 PDT by Ryosuke Niwa
Modified: 2011-09-07 09:10 PDT (History)
6 users (show)

See Also:


Attachments
fixes the bug (7.54 KB, patch)
2011-09-06 19:47 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Ryosuke Niwa 2011-09-06 19:07:29 PDT
It appears that HTMLNames::inputTag isn't initialized properly. m_impl is null. I don't know enough about window.internals to tell what's the right fix for this issue is (might even be a cl.exe / linker bug). I'm going to replace hasTagName check by isInputElement for now and hope for the best.
Comment 2 Ryosuke Niwa 2011-09-06 19:47:10 PDT
Created attachment 106536 [details]
fixes the bug
Comment 3 Ryosuke Niwa 2011-09-06 21:23:56 PDT
Comment on attachment 106536 [details]
fixes the bug

Clearing flags on attachment: 106536

Committed r94633: <http://trac.webkit.org/changeset/94633>
Comment 4 Ryosuke Niwa 2011-09-06 21:24:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Adam Roben (:aroben) 2011-09-07 08:13:05 PDT
Thanks for fixing this!

I think the problem is that we weren't using __declspec(dllimport). From MSDN <http://msdn.microsoft.com/en-us/library/hyx1zcd3(v=vs.71).aspx>:

Note that when you export a variable from a DLL with a .def file, you do not need to specify __declspec(dllexport) on the variable. However, in any file that uses the DLL, you must still use __declspec(dllimport) on the declaration of data.
Comment 6 Ryosuke Niwa 2011-09-07 09:10:40 PDT
(In reply to comment #5)
> Thanks for fixing this!
> 
> I think the problem is that we weren't using __declspec(dllimport). From MSDN <http://msdn.microsoft.com/en-us/library/hyx1zcd3(v=vs.71).aspx>:
> 
> Note that when you export a variable from a DLL with a .def file, you do not need to specify __declspec(dllexport) on the variable. However, in any file that uses the DLL, you must still use __declspec(dllimport) on the declaration of data.

I vaguely remember that dll quirks from my Windows app development days. Can we do that for QualifiedNames so that we can use them in internals.cpp?