Bug 67685 - Update tests for inherit and initial values for -webkit-columns and related CSS properties.
Summary: Update tests for inherit and initial values for -webkit-columns and related C...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luke Macpherson
URL:
Keywords:
Depends on: 67106
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-06 16:44 PDT by Luke Macpherson
Modified: 2011-09-08 11:37 PDT (History)
5 users (show)

See Also:


Attachments
Patch (27.48 KB, patch)
2011-09-06 16:57 PDT, Luke Macpherson
no flags Details | Formatted Diff | Diff
Patch (24.61 KB, patch)
2011-09-06 17:30 PDT, Luke Macpherson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2011-09-06 16:44:36 PDT
Update tests for inherit and initial values for -webkit-columns and related CSS properties.
Comment 1 Luke Macpherson 2011-09-06 16:57:46 PDT
Created attachment 106519 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-09-06 17:01:24 PDT
Comment on attachment 106519 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=106519&action=review

> LayoutTests/fast/multicol/initial-column-values-expected.txt:2
> +ALERT: blah
> +CONSOLE MESSAGE: line 41: TypeError: 'null' is not an object (evaluating 'document.getElementById("parent").style')

Huh?
Comment 3 Luke Macpherson 2011-09-06 17:03:16 PDT
Good point. Let me take a look...
Comment 4 Luke Macpherson 2011-09-06 17:30:13 PDT
Created attachment 106523 [details]
Patch
Comment 5 Luke Macpherson 2011-09-06 17:37:17 PDT
Looks like I had somehow uploaded an in-progress copy. Should be better now.
Comment 6 Eric Seidel (no email) 2011-09-06 18:22:29 PDT
Comment on attachment 106523 [details]
Patch

OK.
Comment 7 WebKit Review Bot 2011-09-08 11:37:20 PDT
Comment on attachment 106523 [details]
Patch

Clearing flags on attachment: 106523

Committed r94773: <http://trac.webkit.org/changeset/94773>
Comment 8 WebKit Review Bot 2011-09-08 11:37:24 PDT
All reviewed patches have been landed.  Closing bug.