Bug 67678 – Remove window.HTMLBlockquoteElement per HTML5 (and DOM Core 1)

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

Remove window.HTMLBlockquoteElement per HTML5 (and DOM Core 1)

[Eric Seidel (no email)]

Created attachment 106497 [details]
Patch

[Darin Adler]

Comment on attachment 106497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=106497&action=review

A quick check around Apple didn’t show any examples of software using the DOMHTMLBlockquoteElement class from Objective-C. If there was any, we would need to find a way to keep that working.

> Source/WebCore/html/HTMLQuoteElement.cpp:47
> -    document()->setUsesBeforeAfterRules(true);
> +    if (hasTagName(qTag))
> +        document()->setUsesBeforeAfterRules(true);

It occurs to me that this compiles in assumptions about the html.css file.

[Eric Seidel (no email)]

Committed r94614: <http://trac.webkit.org/changeset/94614>

[Eric Seidel (no email)]

The Gtk bindings use HTMLBlockquoteElement directly iirc, but I don't understand them (nor do I understand why they're not autogenerated).  It's possible they are autogenerated, they're just autogenerated into the source directory and they'll do the right thing anyway.

[Xan Lopez]

(In reply to comment #4)
> The Gtk bindings use HTMLBlockquoteElement directly iirc, but I don't understand them (nor do I understand why they're not autogenerated).  It's possible they are autogenerated, they're just autogenerated into the source directory and they'll do the right thing anyway.

That's just some small amount of manual code needed for the generated stuff. You can safely kill it.

[Adam Barth]

Attempted GTK build fix in http://trac.webkit.org/changeset/94636

[Eric Seidel (no email)]

Thank you Dr.