Bug 67661 - Move NPAPI headers in bridge to plugins
Summary: Move NPAPI headers in bridge to plugins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-06 11:50 PDT by Anders Carlsson
Modified: 2011-09-06 14:49 PDT (History)
4 users (show)

See Also:


Attachments
Patch (116.16 KB, patch)
2011-09-06 12:01 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (117.65 KB, patch)
2011-09-06 12:45 PDT, Anders Carlsson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-09-06 11:50:28 PDT
Move NPAPI headers in bridge to plugins
Comment 1 Anders Carlsson 2011-09-06 12:01:43 PDT
Created attachment 106458 [details]
Patch
Comment 2 WebKit Review Bot 2011-09-06 12:05:34 PDT
Attachment 106458 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Last 3072 characters of output:
ces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:57:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:57:  uint64_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/plugins/nptypes.h:63:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:65:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:69:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:75:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:80:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:81:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:81:  uint32_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/plugins/nptypes.h:82:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:82:  uint64_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/plugins/nptypes.h:84:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:88:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:89:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:93:  "inttypes.h" already included at Source/WebCore/plugins/nptypes.h:63  [build/include] [4]
Source/WebCore/plugins/nptypes.h:95:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:97:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:97:  "inttypes.h" already included at Source/WebCore/plugins/nptypes.h:63  [build/include] [4]
Source/WebCore/plugins/nptypes.h:104:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:106:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:108:  "stdbool.h" already included at Source/WebCore/plugins/nptypes.h:94  [build/include] [4]
Source/WebCore/plugins/nptypes.h:118:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 360 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Collabora GTK+ EWS bot 2011-09-06 12:16:08 PDT
Comment on attachment 106458 [details]
Patch

Attachment 106458 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9595684
Comment 4 Early Warning System Bot 2011-09-06 12:37:42 PDT
Comment on attachment 106458 [details]
Patch

Attachment 106458 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9554025
Comment 5 Anders Carlsson 2011-09-06 12:45:50 PDT
Created attachment 106468 [details]
Patch
Comment 6 WebKit Review Bot 2011-09-06 12:48:14 PDT
Attachment 106468 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Last 3072 characters of output:
es at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:57:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:57:  uint64_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/plugins/nptypes.h:63:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:65:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:69:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:75:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:80:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:81:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:81:  uint32_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/plugins/nptypes.h:82:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:82:  uint64_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/plugins/nptypes.h:84:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:88:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:89:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:93:  "inttypes.h" already included at Source/WebCore/plugins/nptypes.h:63  [build/include] [4]
Source/WebCore/plugins/nptypes.h:95:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:97:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:97:  "inttypes.h" already included at Source/WebCore/plugins/nptypes.h:63  [build/include] [4]
Source/WebCore/plugins/nptypes.h:104:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:106:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/plugins/nptypes.h:108:  "stdbool.h" already included at Source/WebCore/plugins/nptypes.h:94  [build/include] [4]
Source/WebCore/plugins/nptypes.h:118:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 360 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Darin Adler 2011-09-06 12:48:45 PDT
Comment on attachment 106468 [details]
Patch

Seems fine if we can make it build.
Comment 8 Anders Carlsson 2011-09-06 14:49:12 PDT
Committed r94598: <http://trac.webkit.org/changeset/94598>