Bug 67650 - Compile in ScrollAnimator for Chromium on all platforms by default.
Summary: Compile in ScrollAnimator for Chromium on all platforms by default.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-06 10:09 PDT by Scott Byer
Modified: 2012-03-07 14:44 PST (History)
2 users (show)

See Also:


Attachments
Patch (2.10 KB, patch)
2011-09-06 10:14 PDT, Scott Byer
no flags Details | Formatted Diff | Diff
Rebase (2.08 KB, patch)
2011-09-06 13:50 PDT, Scott Byer
no flags Details | Formatted Diff | Diff
Rebase (2.07 KB, patch)
2011-09-07 15:52 PDT, Scott Byer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Byer 2011-09-06 10:09:23 PDT
Compile in ScrollAnimator for Chromium on all  platforms by default.
Comment 1 Scott Byer 2011-09-06 10:14:45 PDT
Created attachment 106435 [details]
Patch

Cleaning up now that it's compiled in on all Chromium platforms
Comment 2 WebKit Review Bot 2011-09-06 10:16:07 PDT
Attachment 106435 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Last 3072 characters of output:
rc.chromium.org/svn/trunk/src/DEPS@99393")
    should_process: True
    processed: True
    deps_parsed: True
    requirements: set(['./'])
  
    name: media
    url: http://src.chromium.org/svn/trunk/src/media@99393
    should_process: True
    requirements: set(['./'])
  
    name: build
    url: http://src.chromium.org/svn/trunk/src/build@99393
    should_process: True
    requirements: set(['./'])
  
    name: net
    url: http://src.chromium.org/svn/trunk/src/net@99393
    should_process: True
    requirements: set(['./'])
  
    name: tools/data_pack
    url: http://src.chromium.org/svn/trunk/src/tools/data_pack@99393
    should_process: True
    requirements: set(['./'])
  
    name: third_party/ffmpeg
    url: From('chromium_deps', 'src/third_party/ffmpeg')
    should_process: True
    requirements: set(['third_party', 'chromium_deps', './'])
  
    name: tools/generate_stubs
    url: http://src.chromium.org/svn/trunk/src/tools/generate_stubs@99393
    should_process: True
    requirements: set(['./'])
  
    name: third_party/libjpeg_turbo
    url: From('chromium_deps', 'src/third_party/libjpeg_turbo')
    should_process: True
    requirements: set(['third_party', 'chromium_deps', './'])
  
    name: third_party/v8-i18n
    url: From('chromium_deps', 'src/third_party/v8-i18n')
    should_process: True
    requirements: set(['third_party', 'chromium_deps', './'])
  
    name: tools/grit
    url: http://src.chromium.org/svn/trunk/src/tools/grit@99393
    should_process: True
    requirements: set(['./'])
  
    name: base
    url: http://src.chromium.org/svn/trunk/src/base@99393
    should_process: True
    requirements: set(['./'])
  
    name: sql
    url: http://src.chromium.org/svn/trunk/src/sql@99393
    should_process: True
    requirements: set(['./'])
  
    name: v8
    url: From('chromium_deps', 'src/v8')
    should_process: True
    requirements: set(['chromium_deps', './'])
  
    name: testing/gtest
    url: From('chromium_deps', 'src/testing/gtest')
    should_process: True
    requirements: set(['testing', 'chromium_deps', './'])
  
    name: third_party/libwebp
    url: http://src.chromium.org/svn/trunk/src/third_party/libwebp@99393
    should_process: True
    requirements: set(['third_party', './'])
  
    name: googleurl
    url: From('chromium_deps', 'src/googleurl')
    should_process: True
    requirements: set(['chromium_deps', './'])
  
    name: third_party/skia/include
    url: From('chromium_deps', 'src/third_party/skia/include')
    should_process: True
    requirements: set(['third_party', 'chromium_deps', './'])
  
    name: third_party/ots
    url: From('chromium_deps', 'src/third_party/ots')
    should_process: True
    requirements: set(['third_party', 'chromium_deps', './'])
  
    name: third_party/snappy/src
    url: From('chromium_deps', 'src/third_party/snappy/src')
    should_process: True
    requirements: set(['third_party', 'chromium_deps', './'])

Died at Tools/Scripts/update-webkit-chromium line 80.
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Barth 2011-09-06 10:57:00 PDT
Sorry, we're having some dependency trouble with the Chromium DEPS.
Comment 4 Scott Byer 2011-09-06 13:50:03 PDT
Created attachment 106480 [details]
Rebase
Comment 5 Scott Byer 2011-09-07 15:52:27 PDT
Created attachment 106664 [details]
Rebase
Comment 6 WebKit Review Bot 2011-09-08 13:02:59 PDT
Comment on attachment 106664 [details]
Rebase

Clearing flags on attachment: 106664

Committed r94786: <http://trac.webkit.org/changeset/94786>