Bug 67646 – REGRESSION(r94288) build-webkit doesn't work on Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

After r94288 we get the following error:
Undefined subroutine &File::Path::remove_tree called at D:/t/qt-symbian-release/build/Tools/Scripts/webkitdirs.pm line 1698.

On Windows we need this: "use File::Path qw(remove_tree);"

Kristof, could you prepare a patch to fix it?

[Kristóf Kosztyó]

Created attachment 106554 [details]
proposed fix

[WebKit Review Bot]

Comment on attachment 106554 [details]
proposed fix

Rejecting attachment 106554 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
cripts/webkitpy/common/system/executive.py", line 420, in run_command
    close_fds=self._should_close_fds())
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Full output: http://queues.webkit.org/results/9607256

[Csaba Osztrogonác]

Comment on attachment 106554 [details]
proposed fix

Clearing flags on attachment: 106554

Committed r94655: <http://trac.webkit.org/changeset/94655>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

We have to roll it out, because it broke Leopard debug bot, and Qt ARM tester:

"remove_tree" is not exported by the File::Path module
Can't continue after import errors at /home/buildbot/cute1/slaves/armReleaseTest/buildslave/arm-qt-linux-release-arm-test/build/Tools/Scripts/webkitdirs.pm line 36
BEGIN failed--compilation aborted at /home/buildbot/cute1/slaves/armReleaseTest/buildslave/arm-qt-linux-release-arm-test/build/Tools/Scripts/webkitdirs.pm line 36.

[Csaba Osztrogonác]

It was rolled out by http://trac.webkit.org/changeset/94660

[Csaba Osztrogonác]

We got similar problem on the Symbian bot: "remove_tree" is not exported by the File::Path module

[Csaba Osztrogonác]

Zoltan said that we should use rmtree instead of remove_tree.

http://perldoc.perl.org/File/Path.html

[Csaba Osztrogonác]

Fix landed in http://trac.webkit.org/changeset/94663. I hope it will work. :)