Bug 67646 - REGRESSION(r94288) build-webkit doesn't work on Windows
Summary: REGRESSION(r94288) build-webkit doesn't work on Windows
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Blocker
Assignee: Nobody
Depends on: 67703
Blocks: 38054
  Show dependency treegraph
Reported: 2011-09-06 07:58 PDT by Csaba Osztrogonác
Modified: 2011-09-07 05:29 PDT (History)
3 users (show)

See Also:

proposed fix (873 bytes, patch)
2011-09-07 01:22 PDT, Kristóf Kosztyó
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-09-06 07:58:06 PDT
After r94288 we get the following error:
Undefined subroutine &File::Path::remove_tree called at D:/t/qt-symbian-release/build/Tools/Scripts/webkitdirs.pm line 1698.

On Windows we need this: "use File::Path qw(remove_tree);"

Kristof, could you prepare a patch to fix it?
Comment 1 Kristóf Kosztyó 2011-09-07 01:22:11 PDT
Created attachment 106554 [details]
proposed fix
Comment 2 WebKit Review Bot 2011-09-07 01:59:57 PDT
Comment on attachment 106554 [details]
proposed fix

Rejecting attachment 106554 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
cripts/webkitpy/common/system/executive.py", line 420, in run_command
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Full output: http://queues.webkit.org/results/9607256
Comment 3 Csaba Osztrogonác 2011-09-07 02:27:34 PDT
Comment on attachment 106554 [details]
proposed fix

Clearing flags on attachment: 106554

Committed r94655: <http://trac.webkit.org/changeset/94655>
Comment 4 Csaba Osztrogonác 2011-09-07 02:27:42 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Csaba Osztrogonác 2011-09-07 03:23:27 PDT
We have to roll it out, because it broke Leopard debug bot, and Qt ARM tester:

"remove_tree" is not exported by the File::Path module
Can't continue after import errors at /home/buildbot/cute1/slaves/armReleaseTest/buildslave/arm-qt-linux-release-arm-test/build/Tools/Scripts/webkitdirs.pm line 36
BEGIN failed--compilation aborted at /home/buildbot/cute1/slaves/armReleaseTest/buildslave/arm-qt-linux-release-arm-test/build/Tools/Scripts/webkitdirs.pm line 36.
Comment 6 Csaba Osztrogonác 2011-09-07 03:29:52 PDT
It was rolled out by http://trac.webkit.org/changeset/94660
Comment 7 Csaba Osztrogonác 2011-09-07 04:47:05 PDT
We got similar problem on the Symbian bot: "remove_tree" is not exported by the File::Path module
Comment 8 Csaba Osztrogonác 2011-09-07 05:19:14 PDT
Zoltan said that we should use rmtree instead of remove_tree.

Comment 9 Csaba Osztrogonác 2011-09-07 05:29:19 PDT
Fix landed in http://trac.webkit.org/changeset/94663. I hope it will work. :)