CLOSED INVALID67643
[Chromium] Add localizedDescription to WebURLError 
https://bugs.webkit.org/show_bug.cgi?id=67643
Summary [Chromium] Add localizedDescription to WebURLError
Martin Kosiba
Reported 2011-09-06 07:05:21 PDT
The Android WebKit port needs access to the localizedDescription WebCore::ResourceError field. We need to pipe that through to WebURLError.
Attachments
proposed fix (1.81 KB, patch)
2011-09-06 07:50 PDT, Martin Kosiba 		fishd: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2011-09-06 07:14:57 PDT
> The Android WebKit port I think you mean the Chromium port on Android
Martin Kosiba
Comment 2 2011-09-06 07:27:55 PDT
(In reply to comment #1) > > The Android WebKit port > I think you mean the Chromium port on Android Yes.
Martin Kosiba
Comment 3 2011-09-06 07:50:08 PDT
Created attachment 106418 [details] proposed fix
Peter Beverloo
Comment 4 2011-09-06 08:12:16 PDT
+fishd for API review
Steve Block
Comment 5 2011-09-06 08:29:18 PDT
Comment on attachment 106418 [details] proposed fix LGTM, but needs API review from fishd
Darin Fisher (:fishd, Google)
Comment 6 2011-09-08 00:12:20 PDT
Comment on attachment 106418 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=106418&action=review > Source/WebKit/chromium/src/WebURLError.cpp:56 > + localizedDescription = error.localizedDescription(); what about when we copy a WebURLError to a ResourceError? don't you want to copy this field then too? otherwise copying a ResourceError to a WebURLError to a ResourceError will be a lossy operation. can you say more about why you need this information plumbed through here?
Martin Kosiba
Comment 7 2012-06-13 03:37:34 PDT
We don't need this change anymore.
Note You need to log in before you can comment on or make changes to this bug.