Bug 67629 – fast/dom/replaceChild.html may not test what it's supposed to test and may sometimes flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Xianzhu Wang]

The core functionality of what fast/dom/replaceChild.html it's supposed to test is Node.replaceChild(). However, in most cases, it's not executed because the testing finishes before the iframe's onload event handler. For now, the expected result is just the original render tree before replaceChild().

In chance that iframe's onload is executed earlier, the actual result might be different from expected (that is, replaceChild() is executed and the DOM is actually changed.)

[Xianzhu Wang]

Created attachment 106394 [details]
patch

[Darin Adler]

Comment on attachment 106394 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=106394&action=review

> LayoutTests/ChangeLog:4
> +        fast/dom/replaceChild.html may not test what it's supposed to test and may sometimes flaky
> +        https://bugs.webkit.org/show_bug.cgi?id=67629

This change log needs an explanation of what was wrong and how it was fixed.

[Xianzhu Wang]

Comment on attachment 106394 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=106394&action=review

>> LayoutTests/ChangeLog:4
>> +        https://bugs.webkit.org/show_bug.cgi?id=67629
> 
> This change log needs an explanation of what was wrong and how it was fixed.

Done.

[Xianzhu Wang]

Created attachment 106534 [details]
patch for commit

[WebKit Review Bot]

Comment on attachment 106534 [details]
patch for commit

Rejecting attachment 106534 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Review Bot]

Comment on attachment 106534 [details]
patch for commit

Clearing flags on attachment: 106534

Committed r94648: <http://trac.webkit.org/changeset/94648>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.