Bug 67624 - An object's structure should reference the global object responsible for its creation
Summary: An object's structure should reference the global object responsible for its ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-05 20:36 PDT by Oliver Hunt
Modified: 2011-09-06 14:51 PDT (History)
1 user (show)

See Also:


Attachments
Patch (128.64 KB, patch)
2011-09-05 20:46 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (132.17 KB, patch)
2011-09-06 10:11 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (133.21 KB, patch)
2011-09-06 12:19 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (133.32 KB, patch)
2011-09-06 13:01 PDT, Oliver Hunt
barraclough: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-09-05 20:36:36 PDT
An object's structure should reference the global object responsible for its creation
Comment 1 Oliver Hunt 2011-09-05 20:46:29 PDT
Created attachment 106380 [details]
Patch
Comment 2 Early Warning System Bot 2011-09-05 21:00:34 PDT
Comment on attachment 106380 [details]
Patch

Attachment 106380 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9587994
Comment 3 Gyuyoung Kim 2011-09-05 21:09:17 PDT
Comment on attachment 106380 [details]
Patch

Attachment 106380 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9593610
Comment 4 Oliver Hunt 2011-09-06 10:11:28 PDT
Created attachment 106434 [details]
Patch
Comment 5 WebKit Review Bot 2011-09-06 10:13:41 PDT
Attachment 106434 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Last 3072 characters of output:
://src.chromium.org/svn/trunk/src/media@99393
    parsed_url: http://src.chromium.org/svn/trunk/src/media@99393
    should_process: True
    processed: True
    requirements: set(['./'])
  
    name: build
    url: http://src.chromium.org/svn/trunk/src/build@99393
    parsed_url: http://src.chromium.org/svn/trunk/src/build@99393
    should_process: True
    processed: True
    requirements: set(['./'])
  
    name: net
    url: http://src.chromium.org/svn/trunk/src/net@99393
    should_process: True
    requirements: set(['./'])
  
    name: tools/data_pack
    url: http://src.chromium.org/svn/trunk/src/tools/data_pack@99393
    should_process: True
    requirements: set(['./'])
  
    name: third_party/ffmpeg
    url: From('chromium_deps', 'src/third_party/ffmpeg')
    should_process: True
    requirements: set(['third_party', 'chromium_deps', './'])
  
    name: tools/generate_stubs
    url: http://src.chromium.org/svn/trunk/src/tools/generate_stubs@99393
    should_process: True
    requirements: set(['./'])
  
    name: third_party/libjpeg_turbo
    url: From('chromium_deps', 'src/third_party/libjpeg_turbo')
    should_process: True
    requirements: set(['third_party', 'chromium_deps', './'])
  
    name: third_party/v8-i18n
    url: From('chromium_deps', 'src/third_party/v8-i18n')
    should_process: True
    requirements: set(['third_party', 'chromium_deps', './'])
  
    name: tools/grit
    url: http://src.chromium.org/svn/trunk/src/tools/grit@99393
    should_process: True
    requirements: set(['./'])
  
    name: base
    url: http://src.chromium.org/svn/trunk/src/base@99393
    should_process: True
    requirements: set(['./'])
  
    name: sql
    url: http://src.chromium.org/svn/trunk/src/sql@99393
    should_process: True
    requirements: set(['./'])
  
    name: v8
    url: From('chromium_deps', 'src/v8')
    should_process: True
    requirements: set(['chromium_deps', './'])
  
    name: testing/gtest
    url: From('chromium_deps', 'src/testing/gtest')
    should_process: True
    requirements: set(['testing', 'chromium_deps', './'])
  
    name: third_party/libwebp
    url: http://src.chromium.org/svn/trunk/src/third_party/libwebp@99393
    should_process: True
    requirements: set(['third_party', './'])
  
    name: googleurl
    url: From('chromium_deps', 'src/googleurl')
    should_process: True
    requirements: set(['chromium_deps', './'])
  
    name: third_party/skia/include
    url: From('chromium_deps', 'src/third_party/skia/include')
    should_process: True
    requirements: set(['third_party', 'chromium_deps', './'])
  
    name: third_party/ots
    url: From('chromium_deps', 'src/third_party/ots')
    should_process: True
    requirements: set(['third_party', 'chromium_deps', './'])
  
    name: third_party/snappy/src
    url: From('chromium_deps', 'src/third_party/snappy/src')
    should_process: True
    requirements: set(['third_party', 'chromium_deps', './'])

Died at Tools/Scripts/update-webkit-chromium line 80.
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Early Warning System Bot 2011-09-06 10:27:36 PDT
Comment on attachment 106434 [details]
Patch

Attachment 106434 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9591945
Comment 7 Gyuyoung Kim 2011-09-06 10:33:21 PDT
Comment on attachment 106434 [details]
Patch

Attachment 106434 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9595648
Comment 8 Oliver Hunt 2011-09-06 12:19:12 PDT
Created attachment 106461 [details]
Patch
Comment 9 Oliver Hunt 2011-09-06 12:34:02 PDT
I think the qt and efl bots are failing to regenerate all the bindings :-(
Comment 10 Early Warning System Bot 2011-09-06 12:55:42 PDT
Comment on attachment 106461 [details]
Patch

Attachment 106461 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9594781
Comment 11 Oliver Hunt 2011-09-06 13:01:18 PDT
Created attachment 106471 [details]
Patch
Comment 12 Early Warning System Bot 2011-09-06 14:16:37 PDT
Comment on attachment 106471 [details]
Patch

Attachment 106471 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9603010
Comment 13 Gyuyoung Kim 2011-09-06 14:41:25 PDT
Comment on attachment 106471 [details]
Patch

Attachment 106471 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9554029
Comment 14 Gavin Barraclough 2011-09-06 14:41:47 PDT
Comment on attachment 106471 [details]
Patch

You say the Qt failures aren't real, that they're failing to rebuild?  You might want to ping a Qt'er on irc if they're going to need to kick their build bots.
Comment 15 Oliver Hunt 2011-09-06 14:51:15 PDT
Committed r94599