Bug 67589 - [chromium skia] JPEGImageEncoder: hoist constants out of the encoding loop
Summary: [chromium skia] JPEGImageEncoder: hoist constants out of the encoding loop
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: noel gordon
URL:
Keywords:
Depends on: 67618
Blocks: 67402
  Show dependency treegraph
 
Reported: 2011-09-05 01:11 PDT by noel gordon
Modified: 2011-09-07 05:02 PDT (History)
6 users (show)

See Also:


Attachments
Patch (6.21 KB, patch)
2011-09-05 01:32 PDT, noel gordon
no flags Details | Formatted Diff | Diff
Patch fix Mac Chrome compile. (6.22 KB, patch)
2011-09-05 14:30 PDT, noel gordon
no flags Details | Formatted Diff | Diff
Patch for landing. (6.12 KB, patch)
2011-09-05 19:40 PDT, noel gordon
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description noel gordon 2011-09-05 01:11:49 PDT
Change the row converter function signatures to be identical, call them via a function pointer from the encoding loop.
Comment 1 noel gordon 2011-09-05 01:32:16 PDT
Created attachment 106314 [details]
Patch
Comment 2 WebKit Review Bot 2011-09-05 12:55:10 PDT
Comment on attachment 106314 [details]
Patch

Clearing flags on attachment: 106314

Committed r94537: <http://trac.webkit.org/changeset/94537>
Comment 3 WebKit Review Bot 2011-09-05 12:55:14 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Adam Barth 2011-09-05 14:04:36 PDT
See the Bug 67618 for the compile error.
Comment 5 noel gordon 2011-09-05 14:29:18 PDT
Thankyou.  Skia is being compiled into mac chrome, hmmm ...
Comment 6 noel gordon 2011-09-05 14:30:22 PDT
Created attachment 106359 [details]
Patch fix Mac Chrome compile.

Not a work yet, will compile on the mac once there.
Comment 7 noel gordon 2011-09-05 19:40:40 PDT
Created attachment 106376 [details]
Patch for landing.

Chrome mac release+debug compile & test fine for me.
Comment 8 Kenneth Russell 2011-09-06 12:32:23 PDT
Comment on attachment 106376 [details]
Patch for landing.

Looks OK. Let's try again.
Comment 9 WebKit Review Bot 2011-09-06 12:49:25 PDT
Comment on attachment 106376 [details]
Patch for landing.

Clearing flags on attachment: 106376

Committed r94591: <http://trac.webkit.org/changeset/94591>
Comment 10 WebKit Review Bot 2011-09-06 12:49:31 PDT
All reviewed patches have been landed.  Closing bug.