Bug 67576 - [Chromium] Add multiple selection to WebPopupMenuInfo for Android
Summary: [Chromium] Add multiple selection to WebPopupMenuInfo for Android
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 66687
  Show dependency treegraph
 
Reported: 2011-09-04 03:27 PDT by Adam Barth
Modified: 2011-09-04 14:25 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.07 KB, patch)
2011-09-04 03:29 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (3.14 KB, patch)
2011-09-04 13:23 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-09-04 03:27:22 PDT
[Chromium] Add mutliple to WebPopupMenuInfo for Android
Comment 1 Adam Barth 2011-09-04 03:29:17 PDT
Created attachment 106284 [details]
Patch
Comment 2 Adam Barth 2011-09-04 03:30:13 PDT
+fishd for WebKit API review.
Comment 3 Darin Fisher (:fishd, Google) 2011-09-04 08:56:38 PDT
Comment on attachment 106284 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=106284&action=review

R=me, but consider renaming suggestion

> Source/WebKit/chromium/public/WebPopupMenuInfo.h:46
> +    bool multiple;

maybe "multiple" is a little too vague here?  maybe call it "allowMultipleSelection" or "selectMultiple"?

for example, we prefix "index" with "selected" for selectedIndex.
Comment 4 Adam Barth 2011-09-04 13:23:45 PDT
Created attachment 106293 [details]
Patch for landing
Comment 5 WebKit Review Bot 2011-09-04 14:23:29 PDT
Comment on attachment 106293 [details]
Patch for landing

Clearing flags on attachment: 106293

Committed r94507: <http://trac.webkit.org/changeset/94507>
Comment 6 WebKit Review Bot 2011-09-04 14:23:33 PDT
All reviewed patches have been landed.  Closing bug.