Bug 67570 - REGRESSION (r86268): Fix for qt_networkAccessAllowed()
Summary: REGRESSION (r86268): Fix for qt_networkAccessAllowed()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, Regression
Depends on:
Blocks:
 
Reported: 2011-09-03 18:38 PDT by Laszlo Gombos
Modified: 2011-09-03 19:57 PDT (History)
3 users (show)

See Also:


Attachments
1st try (6.58 KB, patch)
2011-09-03 18:46 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2011-09-03 18:38:36 PDT
r86268 changed the USE(QT_BEARER) guard to ENABLE(QT_BEARER) - not consistently but only in one place. This seems an irrelevant change and made the guarded code never execute.

QT_BEARER was introduced to manage BearerManager library dependency in Qt 4.6 however Qt 4.6 is no longer supported on trunk (see 81553), so this could be replaced by the existing QT_NO_BEARERMANAGEMENT QtNetwork guard.
Comment 1 Laszlo Gombos 2011-09-03 18:46:05 PDT
Created attachment 106270 [details]
1st try
Comment 2 Noam Rosenthal 2011-09-03 18:57:29 PDT
Comment on attachment 106270 [details]
1st try

LGTM
Comment 3 WebKit Review Bot 2011-09-03 19:57:53 PDT
Comment on attachment 106270 [details]
1st try

Clearing flags on attachment: 106270

Committed r94499: <http://trac.webkit.org/changeset/94499>
Comment 4 WebKit Review Bot 2011-09-03 19:57:57 PDT
All reviewed patches have been landed.  Closing bug.