Bug 67549 - [chromium] Check in 'build' for compiled binaries first
Summary: [chromium] Check in 'build' for compiled binaries first
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-02 19:07 PDT by Tony Chang
Modified: 2011-09-06 13:31 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.01 KB, patch)
2011-09-02 19:08 PDT, Tony Chang
no flags Details | Formatted Diff | Diff
Patch (3.45 KB, patch)
2011-09-06 10:43 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-09-02 19:07:25 PDT
[chromium] Check in 'build' for compiled binaries first
Comment 1 Tony Chang 2011-09-02 19:08:27 PDT
Created attachment 106237 [details]
Patch
Comment 2 Tony Chang 2011-09-02 19:08:50 PDT
Suggestions on how to test this would be welcome.
Comment 3 Dirk Pranke 2011-09-02 19:27:07 PDT
Comment on attachment 106237 [details]
Patch

The change looks fine to me so I'm R+'ing it. I'm on the fence as to whether writing tests for this is particularly valuable, but if you did want to, the way I'd do it would be to add some tests to chromium_win_unittest that created a port, overrode the port._filesystem field to a dummy object that implemented exists() for various paths, and then called port.build_path to exercise various branches.
Comment 4 Tony Chang 2011-09-06 10:43:16 PDT
Created attachment 106441 [details]
Patch
Comment 5 Tony Chang 2011-09-06 12:06:16 PDT
Test added.  Can you take another look?
Comment 6 WebKit Review Bot 2011-09-06 13:31:45 PDT
Comment on attachment 106441 [details]
Patch

Clearing flags on attachment: 106441

Committed r94592: <http://trac.webkit.org/changeset/94592>
Comment 7 WebKit Review Bot 2011-09-06 13:31:50 PDT
All reviewed patches have been landed.  Closing bug.