Bug 67544 - webkit-patch in a git checkout falls over when a patch removes the last file in a directory
Summary: webkit-patch in a git checkout falls over when a patch removes the last file ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-02 17:32 PDT by James Robinson
Modified: 2011-09-02 17:35 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2011-09-02 17:32:06 PDT
If you have a file foo/bar.txt and try to remove it, by default in git that will remove the foo/ folder as well (since in git directories are not tracked, only files are).  webkit-patch upload/land-cowboy/etc will then die because they attempt to determine the version control system by looking at the enclosing directory of modified files.  The workaround is easy (just mkdir foo and re-run the command) but definitely non-obvious.

This shows up for me quite a bit when doing rebaselines since the optimize step can often remove the last baseline from some platform-specific directory.
Comment 1 Adam Barth 2011-09-02 17:35:21 PDT
I might need some help fixing this because my git foo is somewhat... light.  :)