The following layout test is flaky on all platforms in debug http/tests/security/xssAuditor/dom-write-innerHTML.html Probable cause: I think the setTimeout() is failing the race against the img onerror handler, although I haven't looked too closely. Example failure diff: ALERT: /XSS/
This test is pretty old, was it always flaky? Seems unlikely that notifyDone() can trigger a failure alert, could be an actual bug.
Created attachment 125571 [details] Patch
Comment on attachment 125571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125571&action=review > LayoutTests/http/tests/security/xssAuditor/resources/echo-dom-write-innerHTML.html:9 > -</html> > \ No newline at end of file > +</html> What is the change for?
Comment on attachment 125571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125571&action=review >> LayoutTests/http/tests/security/xssAuditor/resources/echo-dom-write-innerHTML.html:9 >> +</html> > > What is the change for? vi just adds newlines at the end of the file. It's not needed to fix the bug. I can remove the newline again if you'd prefer.
Comment on attachment 125571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125571&action=review >>> LayoutTests/http/tests/security/xssAuditor/resources/echo-dom-write-innerHTML.html:9 >>> +</html> >> >> What is the change for? > > vi just adds newlines at the end of the file. It's not needed to fix the bug. I can remove the newline again if you'd prefer. Then, maybe we can remove the "\ No newline at end of file" line (because now the comment has no meaning).
> Then, maybe we can remove the "\ No newline at end of file" line (because now the comment has no meaning). Oh, that's just added by the diff tool. It's not something that ends up in the repository.
(In reply to comment #6) > > Then, maybe we can remove the "\ No newline at end of file" line (because now the comment has no meaning). > > Oh, that's just added by the diff tool. It's not something that ends up in the repository. Ah, I got it:-)
Comment on attachment 125571 [details] Patch Clearing flags on attachment: 125571 Committed r106785: <http://trac.webkit.org/changeset/106785>
All reviewed patches have been landed. Closing bug.