Bug 67528 – Web Inspector: didMarkDOMContentEvent() should send event of MarkDOMContent type.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Vsevolod Vlasov]

didMarkDOMContentEvent() should send event of MarkDOMContent type.

It is now sending event with TimeStamp type.

http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/inspector/InspectorTimelineAgent.cpp&type=cs&l=334

[Ilya Tikhonovsky]

Created attachment 107822 [details]
[patch] initial version

[Pavel Feldman]

Comment on attachment 107822 [details]
[patch] initial version

View in context: https://bugs.webkit.org/attachment.cgi?id=107822&action=review

> LayoutTests/inspector/timeline/timeline-animation-frame.html:28
> +    function finish()

Is this a part of this patch?

> LayoutTests/inspector/timeline/timeline-dom-content-loaded-event.html:11
> +    InspectorTest.startTimeline(function() { InspectorTest.reloadPage(); });

Tests should not reload the page, please use iframe instead.

[Ilya Tikhonovsky]

Comment on attachment 107822 [details]
[patch] initial version

in the current implementation we don't push these events to the Inspector front-end for resources other than main resource.

[Ilya Tikhonovsky]

Comment on attachment 107822 [details]
[patch] initial version

Clearing flags on attachment: 107822

Committed r95410: <http://trac.webkit.org/changeset/95410>

[Ilya Tikhonovsky]

All reviewed patches have been landed.  Closing bug.

[Ryosuke Niwa]

The test added by this patch has been failing on Snow Leopard:
http://build.webkit.org/old-results/SnowLeopard%20Intel%20Release%20(Tests)/r95410%20(33190)/inspector/timeline/timeline-load-event-pretty-diff.html

[Ilya Tikhonovsky]

I'll fix this

(In reply to comment #6)
> The test added by this patch has been failing on Snow Leopard:
> http://build.webkit.org/old-results/SnowLeopard%20Intel%20Release%20(Tests)/r95410%20(33190)/inspector/timeline/timeline-load-event-pretty-diff.html