Bug 67526 - Add WKContext API to garbage collect JavaScript objects
Summary: Add WKContext API to garbage collect JavaScript objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords:
Depends on: 67546
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-02 14:56 PDT by Ada Chan
Modified: 2011-09-02 20:06 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.80 KB, patch)
2011-09-02 15:05 PDT, Ada Chan
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2011-09-02 14:56:45 PDT
Add WKContextGarbageCollectJavaScriptObjects() which does a garbage collection in JavaScript in the WebProcess.
Comment 1 Ada Chan 2011-09-02 15:05:35 PDT
Created attachment 106204 [details]
Patch
Comment 2 Ada Chan 2011-09-02 15:20:51 PDT
Committed: http://trac.webkit.org/changeset/94454
Comment 3 Julien Chaffraix 2011-09-02 17:35:55 PDT
This patch broke Windows:

5>..\WebProcess\WebProcess.cpp(939) : error C2228: left of '.garbageCollectNow' must have class/struct/union
5>        type is ''unknown-type''
5>..\WebProcess\WebProcess.cpp(939) : error C3861: 'gcController': identifier not found

(http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/20560/steps/compile-webkit/logs/stdio)

Do you have any plans to fix that soon or should we roll the patch out?
Comment 4 Julien Chaffraix 2011-09-02 20:06:41 PDT
FYI the patch got rolled out just after Michael Saboff fixed the release builds. The patch was rolled back in shortly after.