Bug 67522 – REGRESSION: Moving up doesn't work in some cases

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Ryosuke Niwa]

In the attached url, the caret should appear on the second line, NOT on the first line.

i.e. when moving upwards, WebKit not skips lines that are soft-wrapped.

[Ryosuke Niwa]

Created attachment 107089 [details]
fixes the bug

[Eric Seidel (no email)]

Comment on attachment 107089 [details]
fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=107089&action=review

> Source/WebCore/editing/visible_units.cpp:536
> +            Position pos = n->hasTagName(brTag) ? positionBeforeNode(n) : createLegacyEditingPosition(n, caretMaxOffset(n));

Should this be a helper inline?  Is this concept needed elsewhere?

[Ryosuke Niwa]

Comment on attachment 107089 [details]
fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=107089&action=review

>> Source/WebCore/editing/visible_units.cpp:536
>> +            Position pos = n->hasTagName(brTag) ? positionBeforeNode(n) : createLegacyEditingPosition(n, caretMaxOffset(n));
> 
> Should this be a helper inline?  Is this concept needed elsewhere?

Maybe. I think I need to clean up as a part of getting rid of createLegacyEditingPosition. This is a problem whenever we create positions using caretMinOffset/caretMaxOffset.  There's a very interesting interactions between TextIterator and other iteration classes, visible_units, and VisiblePosition and caretMinOffset/caretMaxOffset so I've been postponing it for now.

[Ryosuke Niwa]

Committed r94988: <http://trac.webkit.org/changeset/94988>

[Ryosuke Niwa]

Thanks for the review! landing it now.