Bug 67519 - Add JSC:RegExp functional test data generator
Summary: Add JSC:RegExp functional test data generator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-02 13:29 PDT by Michael Saboff
Modified: 2011-09-02 17:19 PDT (History)
0 users

See Also:


Attachments
Proposed patch (8.22 KB, patch)
2011-09-02 14:04 PDT, Michael Saboff
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2011-09-02 13:29:19 PDT
The functional tests as part of https://bugs.webkit.org/show_bug.cgi?id=67339 are driven by a data file.  This bug is for adding a data generator to automatically generate the data file through normal operation of JavaScriptCore.
Comment 1 Michael Saboff 2011-09-02 14:04:06 PDT
Created attachment 106194 [details]
Proposed patch
Comment 2 Gavin Barraclough 2011-09-02 14:52:57 PDT
Comment on attachment 106194 [details]
Proposed patch

There are some 16-bit/8-bit changes that shouldn't be in this patch, please revert.
r+, but I would prefer to see #undef REGEXP_FUNC_TEST_DATA_GEN be #define REGEXP_FUNC_TEST_DATA_GEN 0, and the tests of it change correspondingly.
Comment 3 Michael Saboff 2011-09-02 17:19:41 PDT
Committed r94468: <http://trac.webkit.org/changeset/94468>