RESOLVED FIXED 67485
[Qt][WK2] 4 tests are failing, skip them 
https://bugs.webkit.org/show_bug.cgi?id=67485
Summary [Qt][WK2] 4 tests are failing, skip them
Kristóf Kosztyó
Reported 2011-09-02 06:50:32 PDT
fast/dom/Window/window-properties.html = TEXT fast/text/complex-preferred-logical-widths.html = TEXT http/tests/loading/empty-urls.html = TEXT http/tests/loading/progress-finished-callback.html = TEXT
Attachments
Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2011-09-02 12:49:24 PDT
It would be useful to record the differences between the expected and actual results for bugs such as this one. It would also be useful to record (approximately) which commit caused the regression. Lastly, it seems that this (and similar) bug needs the following Keyword - Qt, Regression, LayoutTestFailure.
Zoltan Horvath
Comment 2 2011-09-03 05:39:13 PDT
The skip change has been committed in: http://trac.webkit.org/changeset/94416 (In reply to comment #0) > fast/dom/Window/window-properties.html = TEXT This test was added in r94147, it was still failing. > http/tests/loading/empty-urls.html = TEXT This test was added in r94213, it was still failing. > fast/text/complex-preferred-logical-widths.html = TEXT > http/tests/loading/progress-finished-callback.html = TEXT These tests were started to fail before r94137 (the bot stores only 200 revisions).
Csaba Osztrogonác
Comment 3 2011-09-05 00:04:21 PDT
I really don't understand why did you disable a general test, fast/dom/Window/window-properties.html which only needs to be updated. I made the update for qt platform, qt-wk2 needs similar update. http://trac.webkit.org/changeset/94170/trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt I think skipping new failing tests without any attempt to fix isn't a good idea. I agree with Laszlo, at least you should add revision numbers and diffs to the bug report.
Zoltan Horvath
Comment 4 2011-09-05 01:09:47 PDT
(In reply to comment #3) > I really don't understand why did you disable a general test, fast/dom/Window/window-properties.html which only needs to be updated. The answer is easy, maybe you will understand as well: we had't got enough time to investigate the tests, so we did what a gardener should do. ;)
Csaba Osztrogonác
Comment 5 2011-10-19 23:28:06 PDT
*** Bug 67405 has been marked as a duplicate of this bug. ***
Csaba Osztrogonác
Comment 6 2012-02-02 11:00:10 PST
Here is what should have a gardener done instead of headless skipping tests: http://trac.webkit.org/changeset/106571
Note You need to log in before you can comment on or make changes to this bug.