Bug 67485 - [Qt][WK2] 4 tests are failing, skip them
Summary: [Qt][WK2] 4 tests are failing, skip them
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Csaba Osztrogonác
Keywords: LayoutTestFailure, Qt, Regression
: 67405 (view as bug list)
Depends on:
Reported: 2011-09-02 06:50 PDT by Kristóf Kosztyó
Modified: 2012-02-02 11:00 PST (History)
4 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Kristóf Kosztyó 2011-09-02 06:50:32 PDT
fast/dom/Window/window-properties.html = TEXT
fast/text/complex-preferred-logical-widths.html = TEXT
http/tests/loading/empty-urls.html = TEXT
http/tests/loading/progress-finished-callback.html = TEXT
Comment 1 Laszlo Gombos 2011-09-02 12:49:24 PDT
It would be useful to record the differences between the expected and actual results for bugs such as this one. It would also be useful to record (approximately) which commit caused the regression. Lastly, it seems that this (and similar) bug needs the following Keyword - Qt, Regression, LayoutTestFailure.
Comment 2 Zoltan Horvath 2011-09-03 05:39:13 PDT
The skip change has been committed in: http://trac.webkit.org/changeset/94416

(In reply to comment #0)

> fast/dom/Window/window-properties.html = TEXT
This test was added in r94147, it was still failing.

> http/tests/loading/empty-urls.html = TEXT
This test was added in r94213, it was still failing.

> fast/text/complex-preferred-logical-widths.html = TEXT
> http/tests/loading/progress-finished-callback.html = TEXT

These tests were started to fail before r94137 (the bot stores only 200 revisions).
Comment 3 Csaba Osztrogonác 2011-09-05 00:04:21 PDT
I really don't understand why did you disable a general test, fast/dom/Window/window-properties.html which only needs to be updated.

I made the update for qt platform, qt-wk2 needs similar update.

I think skipping new failing tests without any attempt to fix isn't a good idea. I agree with Laszlo, at least you should add revision numbers and diffs to the bug report.
Comment 4 Zoltan Horvath 2011-09-05 01:09:47 PDT
(In reply to comment #3)
> I really don't understand why did you disable a general test, fast/dom/Window/window-properties.html which only needs to be updated.

The answer is easy, maybe you will understand as well:  we had't got enough time to investigate the tests, so we did what a gardener should do. ;)
Comment 5 Csaba Osztrogonác 2011-10-19 23:28:06 PDT
*** Bug 67405 has been marked as a duplicate of this bug. ***
Comment 6 Csaba Osztrogonác 2012-02-02 11:00:10 PST
Here is what should have a gardener done instead of headless skipping tests: