[CMake] Detect the operating system in a more generic way.
Created attachment 106122 [details] Patch
Comment on attachment 106122 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106122&action=review > Source/CMakeLists.txt:76 > +IF (UNIX) ok > Source/CMakeLists.txt:82 > +ELSEIF (WIN32) WIN32 isn't defined for Windows CE!
(In reply to comment #2) > > Source/CMakeLists.txt:82 > > +ELSEIF (WIN32) > > WIN32 isn't defined for Windows CE! Sorry, will bake a new patch soon. By the way, is this really an expected behavior from CMake? Is WinCE different enough for it not to be recognized as WIN32 (as it also works for windows 64)?
Created attachment 106125 [details] Patch
Comment on attachment 106125 [details] Patch LGTM
(In reply to comment #3) > (In reply to comment #2) > > > Source/CMakeLists.txt:82 > > > +ELSEIF (WIN32) > > > > WIN32 isn't defined for Windows CE! > > Sorry, will bake a new patch soon. By the way, is this really an expected behavior from CMake? Is WinCE different enough for it not to be recognized as WIN32 (as it also works for windows 64)? Not sure, but since there is no offical WinCE support at the moment, it's hard to say what's correct/wrog. If it's ok for you i'd like to keep the windows part as it for now.
(In reply to comment #6) > (In reply to comment #3) > > Sorry, will bake a new patch soon. By the way, is this really an expected behavior from CMake? Is WinCE different enough for it not to be recognized as WIN32 (as it also works for windows 64)? > > Not sure, but since there is no offical WinCE support at the moment, it's hard to say what's correct/wrog. Do you mean there's no official WinCE support in CMake itself? > If it's ok for you i'd like to keep the windows part as it for now. No problem.
CC'ing reviewers.
Comment on attachment 106125 [details] Patch Clearing flags on attachment: 106125 Committed r95986: <http://trac.webkit.org/changeset/95986>
All reviewed patches have been landed. Closing bug.