Bug 67453 – REGRESSION(r94274): FormManagerTest.PreviewForm and FillFormNonEmptyField fail on chromium

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Ryosuke Niwa]

After r94274, FormManagerTest.PreviewForm and FillFormNonEmptyField are failing on chromium.

[Ryosuke Niwa]

http://code.google.com/p/chromium/issues/detail?id=95048

Comment 6 by [e-mail], Today (2 hours ago)
It looks like the problem is that setSuggestedValue() is not updating the renderer.

> All these auto-fill tests are super annoying.  Someone should make a corresponding WebKit test so that I don't have to debug chromium.  I'll debug it tomorrow.

Or you could add layout tests along with your fix ;)  There aren't a lot of existing layout tests in this area because DRT only recently gained the necessary infrastructure to write such tests.

Comment 8 by [e-mail], Today (2 hours ago)
Indeed. I bet we just need to replace the call to updateFromElement by a call to updateInnerTextValue in HTMLInputElement::setSuggestedValue.
http://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLInputElement.cpp#L1066

[Ryosuke Niwa]

Created attachment 106269 [details]
fixes the bug

[Ryosuke Niwa]

Note that the same change has been tried on the try bots and had green runs:
http://build.chromium.org/p/tryserver.chromium/builders/win/builds/53193
http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/47289
http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/47269

[Collabora GTK+ EWS bot]

Comment on attachment 106269 [details]
fixes the bug

Attachment 106269 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9587405

[Darin Adler]

Comment on attachment 106269 [details]
fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=106269&action=review

> Source/WebCore/ChangeLog:8
> +        Fixed the bug by updating inner text value in setSuggestedValue.

I couldn’t find that change in the patch.

[Ryosuke Niwa]

(In reply to comment #5)
> (From update of attachment 106269 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=106269&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Fixed the bug by updating inner text value in setSuggestedValue.
> 
> I couldn’t find that change in the patch.

Oops, I apparently reverted the change temporarily to test my test and forget to un-revert it.  Will post a new patch in a few minutes.

[Ryosuke Niwa]

Created attachment 106278 [details]
Fixed win & gtk builds

[Collabora GTK+ EWS bot]

Comment on attachment 106278 [details]
Fixed win & gtk builds

Attachment 106278 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9590321

[Kent Tamura]

Comment on attachment 106278 [details]
Fixed win & gtk builds

Looks good.

[Ryosuke Niwa]

Can someone who has access to GTK+ environment tell me what the C++ mangled name for WebCore::HTMLInputElement::suggestedValue() const is?

[Ryosuke Niwa]

(In reply to comment #10)
> Can someone who has access to GTK+ environment tell me what the C++ mangled name for WebCore::HTMLInputElement::suggestedValue() const is?

It should be _ZNK7WebCore16HTMLInputElement14suggestedValueEv.

[Ryosuke Niwa]

Committed r94586: <http://trac.webkit.org/changeset/94586>