Add missing Event constructors to DOMWindow.idl
Created attachment 106048 [details] Patch
Committed r94355: <http://trac.webkit.org/changeset/94355>
This patch appears to have broken Windows, Qt, and other builds.
http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/20509/steps/compile-webkit/logs/stdio 6>WebCore.lib(DerivedSources.obj) : error LNK2019: unresolved external symbol "public: static class JSC::JSValue __cdecl WebCore::JSBeforeProcessEvent::getConstructor(class JSC::ExecState *,class JSC::JSGlobalObject *)" (?getConstructor@JSBeforeProcessEvent@WebCore@@SA?AVJSValue@JSC@@PAVExecState@4@PAVJSGlobalObject@4@@Z) referenced in function "class JSC::JSValue __cdecl WebCore::jsDOMWindowBeforeProcessEventConstructor(class JSC::ExecState *,class JSC::JSValue,class JSC::Identifier const &)" (?jsDOMWindowBeforeProcessEventConstructor@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@V23@ABVIdentifier@3@@Z) 6>C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin\WebKit.dll : fatal error LNK1120: 1 unresolved externals
Per IRC discussion with andersca, I reverted the patch in http://trac.webkit.org/changeset/94367 because it was making the entire tree red for a while.
Yeah, looks like the BeforeProcess event is not really being created correctly (or even wrapped :( ). Will fix that first.
(In reply to comment #6) > Yeah, looks like the BeforeProcess event is not really being created correctly (or even wrapped :( ). Will fix that first. Actually, it looks like BeforeProcess doesn't do anything, and was mean to be replaced over a year ago (https://bugs.webkit.org/show_bug.cgi?id=40484). I will have to ask Brady what's up tomorrow.
Created attachment 106160 [details] Patch
Comment on attachment 106160 [details] Patch Attachment 106160 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9578917
Committed r94493: <http://trac.webkit.org/changeset/94493>