RESOLVED FIXED 67449
Add missing Event constructors to DOMWindow.idl 
https://bugs.webkit.org/show_bug.cgi?id=67449
Summary Add missing Event constructors to DOMWindow.idl
Sam Weinig
Reported 2011-09-01 15:43:03 PDT
Add missing Event constructors to DOMWindow.idl
Attachments
Patch (24.42 KB, patch)
2011-09-01 15:44 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (20.54 KB, patch)
2011-09-02 11:07 PDT, Sam Weinig 		andersca: review+
gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-09-01 15:44:37 PDT
Created attachment 106048 [details] Patch
Sam Weinig
Comment 2 2011-09-01 15:47:43 PDT
Committed r94355: <http://trac.webkit.org/changeset/94355>
Ryosuke Niwa
Comment 3 2011-09-01 16:08:07 PDT
This patch appears to have broken Windows, Qt, and other builds.
Ryosuke Niwa
Comment 4 2011-09-01 16:13:13 PDT
http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/20509/steps/compile-webkit/logs/stdio 6>WebCore.lib(DerivedSources.obj) : error LNK2019: unresolved external symbol "public: static class JSC::JSValue __cdecl WebCore::JSBeforeProcessEvent::getConstructor(class JSC::ExecState *,class JSC::JSGlobalObject *)" (?getConstructor@JSBeforeProcessEvent@WebCore@@SA?AVJSValue@JSC@@PAVExecState@4@PAVJSGlobalObject@4@@Z) referenced in function "class JSC::JSValue __cdecl WebCore::jsDOMWindowBeforeProcessEventConstructor(class JSC::ExecState *,class JSC::JSValue,class JSC::Identifier const &)" (?jsDOMWindowBeforeProcessEventConstructor@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@V23@ABVIdentifier@3@@Z) 6>C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin\WebKit.dll : fatal error LNK1120: 1 unresolved externals
Ryosuke Niwa
Comment 5 2011-09-01 17:11:15 PDT
Per IRC discussion with andersca, I reverted the patch in http://trac.webkit.org/changeset/94367 because it was making the entire tree red for a while.
Sam Weinig
Comment 6 2011-09-01 18:47:28 PDT
Yeah, looks like the BeforeProcess event is not really being created correctly (or even wrapped :( ). Will fix that first.
Sam Weinig
Comment 7 2011-09-01 21:49:32 PDT
(In reply to comment #6) > Yeah, looks like the BeforeProcess event is not really being created correctly (or even wrapped :( ). Will fix that first. Actually, it looks like BeforeProcess doesn't do anything, and was mean to be replaced over a year ago (https://bugs.webkit.org/show_bug.cgi?id=40484). I will have to ask Brady what's up tomorrow.
Sam Weinig
Comment 8 2011-09-02 11:07:49 PDT
Created attachment 106160 [details] Patch
Gyuyoung Kim
Comment 9 2011-09-02 11:38:52 PDT
Comment on attachment 106160 [details] Patch Attachment 106160 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9578917
Sam Weinig
Comment 10 2011-09-03 12:25:52 PDT
Committed r94493: <http://trac.webkit.org/changeset/94493>
Note You need to log in before you can comment on or make changes to this bug.