Bug 67449 - Add missing Event constructors to DOMWindow.idl
Summary: Add missing Event constructors to DOMWindow.idl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-01 15:43 PDT by Sam Weinig
Modified: 2011-09-03 12:25 PDT (History)
1 user (show)

See Also:


Attachments
Patch (24.42 KB, patch)
2011-09-01 15:44 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (20.54 KB, patch)
2011-09-02 11:07 PDT, Sam Weinig
andersca: review+
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-09-01 15:43:03 PDT
Add missing Event constructors to DOMWindow.idl
Comment 1 Sam Weinig 2011-09-01 15:44:37 PDT
Created attachment 106048 [details]
Patch
Comment 2 Sam Weinig 2011-09-01 15:47:43 PDT
Committed r94355: <http://trac.webkit.org/changeset/94355>
Comment 3 Ryosuke Niwa 2011-09-01 16:08:07 PDT
This patch appears to have broken Windows, Qt, and other builds.
Comment 4 Ryosuke Niwa 2011-09-01 16:13:13 PDT
http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/20509/steps/compile-webkit/logs/stdio

6>WebCore.lib(DerivedSources.obj) : error LNK2019: unresolved external symbol "public: static class JSC::JSValue __cdecl WebCore::JSBeforeProcessEvent::getConstructor(class JSC::ExecState *,class JSC::JSGlobalObject *)" (?getConstructor@JSBeforeProcessEvent@WebCore@@SA?AVJSValue@JSC@@PAVExecState@4@PAVJSGlobalObject@4@@Z) referenced in function "class JSC::JSValue __cdecl WebCore::jsDOMWindowBeforeProcessEventConstructor(class JSC::ExecState *,class JSC::JSValue,class JSC::Identifier const &)" (?jsDOMWindowBeforeProcessEventConstructor@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@V23@ABVIdentifier@3@@Z)
6>C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin\WebKit.dll : fatal error LNK1120: 1 unresolved externals
Comment 5 Ryosuke Niwa 2011-09-01 17:11:15 PDT
Per IRC discussion with andersca, I reverted the patch in http://trac.webkit.org/changeset/94367 because it was making the entire tree red for a while.
Comment 6 Sam Weinig 2011-09-01 18:47:28 PDT
Yeah, looks like the BeforeProcess event is not really being created correctly (or even wrapped :( ).  Will fix that first.
Comment 7 Sam Weinig 2011-09-01 21:49:32 PDT
(In reply to comment #6)
> Yeah, looks like the BeforeProcess event is not really being created correctly (or even wrapped :( ).  Will fix that first.

Actually, it looks like BeforeProcess doesn't do anything, and was mean to be replaced over a year ago (https://bugs.webkit.org/show_bug.cgi?id=40484). I will have to ask Brady what's up tomorrow.
Comment 8 Sam Weinig 2011-09-02 11:07:49 PDT
Created attachment 106160 [details]
Patch
Comment 9 Gyuyoung Kim 2011-09-02 11:38:52 PDT
Comment on attachment 106160 [details]
Patch

Attachment 106160 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9578917
Comment 10 Sam Weinig 2011-09-03 12:25:52 PDT
Committed r94493: <http://trac.webkit.org/changeset/94493>