Related to bug #65896 the Qt number input wouldn't render its input number in RTL properly. Also, Plastique style doesn't look as intended.
Created attachment 106038 [details] Mac
Created attachment 106040 [details] Windows Classic
Created attachment 106041 [details] Windows Vista/7
Created attachment 106042 [details] X11 windows style
Created attachment 106043 [details] X11 Plastique
Created attachment 106044 [details] Proposed Patch
Attachment 106044 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/platform/qt/fast/forms/input-a..." exit_code: 1 Source/WebCore/platform/qt/RenderThemeQt.cpp:1128: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/platform/qt/RenderThemeQt.cpp:1130: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.
This is a false positive, I intentionally chose to be explicit with the != 0 comparison for readability. Happy to edit if anyone disagrees with this choice.
(In reply to comment #8) > This is a false positive, I intentionally chose to be explicit with the != 0 comparison for readability. Happy to edit if anyone disagrees with this choice. It's a pretty useless pre-optimization anyways, I'll just remove those checks I think.
Created attachment 106081 [details] Patch w/o pre-optimization/style issues
Created attachment 106082 [details] Patch w/o pre-optimization/style issues
Created attachment 106131 [details] Proposed Patch I'm a donkey and didn't rebase some commits and my patch didn't include my changelog commit.
Comment on attachment 106131 [details] Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106131&action=review r=me > Source/WebCore/platform/qt/RenderThemeQt.cpp:1121 > + // QPlastiqueStyle looks best when the spin buttons are flush with the frame's edge. You made me look up 'flush', you donkey. :)
Comment on attachment 106131 [details] Proposed Patch Clearing flags on attachment: 106131 Committed r94419: <http://trac.webkit.org/changeset/94419>
All reviewed patches have been landed. Closing bug.