Emacs enhancements for working on WebKit.
Created attachment 106641 [details] Patch
Created attachment 119470 [details] Patch
I don't understand all of it, but in general LGTM. (Note that I am not a reviewer.) One note, if I M-x c-adaptive-wrap-mode to toggle off and then back on, I get an error: progn: Symbol's value as variable is void: whitespace-mode Also, one message says "Perquisites" when it should probably say "Prerequisites". But the no-indentation-in-namespaces thing alone is worth it :)
Created attachment 119496 [details] Patch
I'm not an emacs user, but I know a bunch of the Safari team are. I suspect some common emacs settings would be a welcome addition to the project. :)
Comment on attachment 119496 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119496&action=review We don't have to have '.dir-local.el' at top-level since it forces every emacs users to use this settings. I prefer 'opt-in' to 'opt-out'. I am afraid that some settings conflicts personal settings. Could you move this file to Tools/emacs as 'sample-dir-local.el'? If we have top-level '.dir-local.el', it should contain only minimum settings which can be widely accepted and which never conflicts settings of every emacs users. > Tools/emacs/webkit.el:1 > +; Copyright (c) 2011, Google Inc. All rights reserved. It should be 2012. > Tools/emacs/webkit.el:118 > +(defun c-mode-adaptive-indent (beg end) You should use 'webkit-' prefix in all functions on this file. We don't have elisp style guide for WebKit, but it might be better to follow general elisp's convention. At least, I don't want to eval this file since it might conflict my own functions.
Comment on attachment 119496 [details] Patch rs=me.