Bug 67431 - [CSS3 Backgrounds and Borders] Implement border-image-repeat
Summary: [CSS3 Backgrounds and Borders] Implement border-image-repeat
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 27583
  Show dependency treegraph
 
Reported: 2011-09-01 13:37 PDT by Dave Hyatt
Modified: 2011-09-02 08:59 PDT (History)
3 users (show)

See Also:


Attachments
Patch (69.80 KB, patch)
2011-09-01 13:43 PDT, Dave Hyatt
no flags Details | Formatted Diff | Diff
Patch (69.58 KB, patch)
2011-09-01 13:52 PDT, Dave Hyatt
no flags Details | Formatted Diff | Diff
Fix more style complaints. (69.53 KB, patch)
2011-09-01 13:54 PDT, Dave Hyatt
bdakin: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2011-09-01 13:37:03 PDT
This bug tracks the implementation of border-image-repeat.
Comment 1 Dave Hyatt 2011-09-01 13:43:03 PDT
Created attachment 106019 [details]
Patch
Comment 2 WebKit Review Bot 2011-09-01 13:45:46 PDT
Attachment 106019 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/platform/graphics/Image.cpp:161:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/css/CSSParser.cpp:5368:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSParser.h:170:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSelector.cpp:5764:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebCore/css/CSSStyleSelector.cpp:5781:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 5 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2011-09-01 13:52:51 PDT
Created attachment 106023 [details]
Patch
Comment 4 Dave Hyatt 2011-09-01 13:54:49 PDT
Created attachment 106024 [details]
Fix more style complaints.
Comment 5 WebKit Review Bot 2011-09-01 14:01:52 PDT
Attachment 106023 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/css/CSSParser.cpp:5368:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSParser.h:170:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSelector.cpp:5781:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 3 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 WebKit Review Bot 2011-09-01 14:03:23 PDT
Attachment 106024 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/css/CSSParser.cpp:5368:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSParser.h:170:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSelector.cpp:5793:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
Total errors found: 3 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Beth Dakin 2011-09-01 15:06:10 PDT
Comment on attachment 106024 [details]
Fix more style complaints.

View in context: https://bugs.webkit.org/attachment.cgi?id=106024&action=review

> Source/WebCore/css/CSSParser.cpp:5373
> +    if (isBorderImageRepeatKeyword(val->id))

Maybe I am reading this wrong, but it seems like this would read clearer as:

if (isBorderImageRepeatKeyword(val->id))
    return false;

firstValue = primitiveValueCache()->createIdentifierValue(val->id);
Comment 8 WebKit Review Bot 2011-09-01 15:15:18 PDT
Comment on attachment 106024 [details]
Fix more style complaints.

Attachment 106024 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9580388

New failing tests:
svg/css/getComputedStyle-basic.xhtml
fast/borders/border-image-repeat.html
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-without-renderer.html
Comment 9 Dave Hyatt 2011-09-02 08:59:32 PDT
Fixed in r94420.