Bug 67431 – [CSS3 Backgrounds and Borders] Implement border-image-repeat

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dave Hyatt]

This bug tracks the implementation of border-image-repeat.

[Dave Hyatt]

Created attachment 106019 [details]
Patch

[WebKit Review Bot]

Attachment 106019 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/platform/graphics/Image.cpp:161:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/css/CSSParser.cpp:5368:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSParser.h:170:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSelector.cpp:5764:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebCore/css/CSSStyleSelector.cpp:5781:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 5 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 106023 [details]
Patch

[Dave Hyatt]

Created attachment 106024 [details]
Fix more style complaints.

[WebKit Review Bot]

Attachment 106023 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/css/CSSParser.cpp:5368:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSParser.h:170:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSelector.cpp:5781:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 3 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Attachment 106024 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/css/CSSParser.cpp:5368:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSParser.h:170:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSelector.cpp:5793:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
Total errors found: 3 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Beth Dakin]

Comment on attachment 106024 [details]
Fix more style complaints.

View in context: https://bugs.webkit.org/attachment.cgi?id=106024&action=review

> Source/WebCore/css/CSSParser.cpp:5373
> +    if (isBorderImageRepeatKeyword(val->id))

Maybe I am reading this wrong, but it seems like this would read clearer as:

if (isBorderImageRepeatKeyword(val->id))
    return false;

firstValue = primitiveValueCache()->createIdentifierValue(val->id);

[WebKit Review Bot]

Comment on attachment 106024 [details]
Fix more style complaints.

Attachment 106024 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9580388

New failing tests:
svg/css/getComputedStyle-basic.xhtml
fast/borders/border-image-repeat.html
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-without-renderer.html

[Dave Hyatt]

Fixed in r94420.