Bug 67420 - Unzip initialization lists and constructors in JSCell hierarchy (5/7)
Summary: Unzip initialization lists and constructors in JSCell hierarchy (5/7)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on: 67174 67693 67698
Blocks: 66567 67692
  Show dependency treegraph
 
Reported: 2011-09-01 10:58 PDT by Mark Hahnenberg
Modified: 2011-09-09 14:42 PDT (History)
3 users (show)

See Also:


Attachments
Patch (112.42 KB, patch)
2011-09-01 19:09 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff
Reset test bindings (114.99 KB, patch)
2011-09-01 19:15 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff
Patch (118.59 KB, patch)
2011-09-03 19:55 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff
Fixing spacing issue (118.59 KB, patch)
2011-09-03 21:59 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff
Rebasing (118.89 KB, patch)
2011-09-06 16:41 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff
Patch (120.06 KB, patch)
2011-09-07 18:57 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff
Patch (119.92 KB, patch)
2011-09-08 10:26 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff
Resetting bindings (119.86 KB, patch)
2011-09-09 11:10 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2011-09-01 10:58:33 PDT
This is the fifth level of the unzipping process described in https://bugs.webkit.org/show_bug.cgi?id=66567.
Comment 1 Mark Hahnenberg 2011-09-01 19:09:52 PDT
Created attachment 106083 [details]
Patch
Comment 2 Mark Hahnenberg 2011-09-01 19:15:11 PDT
Created attachment 106084 [details]
Reset test bindings
Comment 3 Early Warning System Bot 2011-09-01 19:32:11 PDT
Comment on attachment 106084 [details]
Reset test bindings

Attachment 106084 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9582484
Comment 4 Mark Hahnenberg 2011-09-03 19:55:49 PDT
Created attachment 106274 [details]
Patch
Comment 5 Darin Adler 2011-09-03 21:04:06 PDT
Comment on attachment 106274 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=106274&action=review

> Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:10
> -    ??0DateInstance@JSC@@IAE@PAVExecState@1@PAVStructure@1@N@Z
> +   ??0DateInstance@JSC@@IAE@PAVExecState@1@PAVStructure@1@@Z
>      ??0DefaultGCActivityCallback@JSC@@QAE@PAVHeap@1@@Z
>      ??0DropAllLocks@JSLock@JSC@@QAE@W4JSLockBehavior@2@@Z
> -    ??0DynamicGlobalObjectScope@JSC@@QAE@AAVJSGlobalData@1@PAVJSGlobalObject@1@@Z  
> -    ??0InternalFunction@JSC@@IAE@PAVJSGlobalData@1@PAVJSGlobalObject@1@PAVStructure@1@ABVIdentifier@1@@Z
> +    ??0DynamicGlobalObjectScope@JSC@@QAE@AAVJSGlobalData@1@PAVJSGlobalObject@1@@Z 
> +   ??0InternalFunction@JSC@@IAE@PAVJSGlobalObject@1@PAVStructure@1@@Z

Indentation level seems inconsistent here.

> Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:22
> -    ??0StringObject@JSC@@IAE@AAVJSGlobalData@1@PAVStructure@1@PAVJSString@1@@Z
> +   ??0StringObject@JSC@@IAE@AAVJSGlobalData@1@PAVStructure@1@@Z

Indentation level seems inconsistent here.

> Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:186
>      ?finalize@WeakHandleOwner@JSC@@UAEXV?$Handle@W4Unknown@JSC@@@2@PAX@Z
> +   ?finishCreation@DateInstance@JSC@@IAEXAAVJSGlobalData@2@N@Z
> +   ?finishCreation@InternalFunction@JSC@@IAEXAAVJSGlobalData@2@PAVJSGlobalObject@2@ABVIdentifier@2@@Z
>      ?finishCreation@JSArray@JSC@@IAEXAAVJSGlobalData@2@@Z
>      ?finishCreation@JSArray@JSC@@IAEXAAVJSGlobalData@2@ABVArgList@2@@Z
>      ?finishCreation@JSFunction@JSC@@IAEXPAVExecState@2@PAVJSGlobalObject@2@HABVIdentifier@2@PAVExecutableBase@2@@Z
>      ?finishCreation@JSObjectWithGlobalObject@JSC@@IAEXAAVJSGlobalData@2@PAVJSGlobalObject@2@@Z
> +   ?finishCreation@RegExpObject@JSC@@IAEXPAVJSGlobalObject@2@@Z
> +   ?finishCreation@StringObject@JSC@@IAEXAAVJSGlobalData@2@PAVJSString@2@@Z
>      ?focus@Profile@JSC@@QAEXPBVProfileNode@2@@Z

Indentation level seems inconsistent here.
Comment 6 Mark Hahnenberg 2011-09-03 21:59:23 PDT
Created attachment 106277 [details]
Fixing spacing issue
Comment 7 Geoffrey Garen 2011-09-06 14:46:06 PDT
Comment on attachment 106277 [details]
Fixing spacing issue

Marking cq+ since Mark is not a committer yet.
Comment 8 WebKit Review Bot 2011-09-06 15:05:14 PDT
Comment on attachment 106277 [details]
Fixing spacing issue

Rejecting attachment 106277 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Source/WebKit2/WebProcess/Plugins/Netscape/JSNPMethod.h
Hunk #2 succeeded at 38 with fuzz 2.
patching file Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.cpp
Hunk #2 FAILED at 68.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.cpp.rej
patching file Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/9601140
Comment 9 Mark Hahnenberg 2011-09-06 16:41:19 PDT
Created attachment 106517 [details]
Rebasing
Comment 10 Geoffrey Garen 2011-09-06 16:55:47 PDT
Comment on attachment 106517 [details]
Rebasing

rs=me
Comment 11 WebKit Review Bot 2011-09-06 19:12:45 PDT
Comment on attachment 106517 [details]
Rebasing

Clearing flags on attachment: 106517

Committed r94627: <http://trac.webkit.org/changeset/94627>
Comment 12 WebKit Review Bot 2011-09-06 19:12:51 PDT
All reviewed patches have been landed.  Closing bug.
Comment 13 Ryosuke Niwa 2011-09-06 21:20:05 PDT
It appears that this patch broke Snow Leopard build:
http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Build%29/builds/33559/steps/compile-webkit/logs/stdio
Comment 14 Csaba Osztrogonác 2011-09-06 23:37:50 PDT
And it broke ecma/Date/15.9.5.js JSC test and fast/js/exception-properties.html layout test on GTK and Qt bots.
Comment 15 Csaba Osztrogonác 2011-09-07 00:02:26 PDT
SL build was fixed by http://trac.webkit.org/changeset/94632, but tests were still broken, so I had to rollout the original patch with SL buildfix:

http://trac.webkit.org/changeset/94644
Comment 17 Mark Hahnenberg 2011-09-07 18:57:01 PDT
Created attachment 106681 [details]
Patch
Comment 18 Early Warning System Bot 2011-09-07 19:12:10 PDT
Comment on attachment 106681 [details]
Patch

Attachment 106681 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9603986
Comment 19 Mark Hahnenberg 2011-09-08 10:26:13 PDT
Created attachment 106757 [details]
Patch
Comment 20 Mark Hahnenberg 2011-09-09 11:10:47 PDT
Created attachment 106888 [details]
Resetting bindings
Comment 21 Geoffrey Garen 2011-09-09 13:18:56 PDT
Comment on attachment 106888 [details]
Resetting bindings

r=me
Comment 22 WebKit Review Bot 2011-09-09 14:42:25 PDT
Comment on attachment 106888 [details]
Resetting bindings

Clearing flags on attachment: 106888

Committed r94875: <http://trac.webkit.org/changeset/94875>
Comment 23 WebKit Review Bot 2011-09-09 14:42:31 PDT
All reviewed patches have been landed.  Closing bug.