This is the fifth level of the unzipping process described in https://bugs.webkit.org/show_bug.cgi?id=66567.
Created attachment 106083 [details] Patch
Created attachment 106084 [details] Reset test bindings
Comment on attachment 106084 [details] Reset test bindings Attachment 106084 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9582484
Created attachment 106274 [details] Patch
Comment on attachment 106274 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106274&action=review > Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:10 > - ??0DateInstance@JSC@@IAE@PAVExecState@1@PAVStructure@1@N@Z > + ??0DateInstance@JSC@@IAE@PAVExecState@1@PAVStructure@1@@Z > ??0DefaultGCActivityCallback@JSC@@QAE@PAVHeap@1@@Z > ??0DropAllLocks@JSLock@JSC@@QAE@W4JSLockBehavior@2@@Z > - ??0DynamicGlobalObjectScope@JSC@@QAE@AAVJSGlobalData@1@PAVJSGlobalObject@1@@Z > - ??0InternalFunction@JSC@@IAE@PAVJSGlobalData@1@PAVJSGlobalObject@1@PAVStructure@1@ABVIdentifier@1@@Z > + ??0DynamicGlobalObjectScope@JSC@@QAE@AAVJSGlobalData@1@PAVJSGlobalObject@1@@Z > + ??0InternalFunction@JSC@@IAE@PAVJSGlobalObject@1@PAVStructure@1@@Z Indentation level seems inconsistent here. > Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:22 > - ??0StringObject@JSC@@IAE@AAVJSGlobalData@1@PAVStructure@1@PAVJSString@1@@Z > + ??0StringObject@JSC@@IAE@AAVJSGlobalData@1@PAVStructure@1@@Z Indentation level seems inconsistent here. > Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:186 > ?finalize@WeakHandleOwner@JSC@@UAEXV?$Handle@W4Unknown@JSC@@@2@PAX@Z > + ?finishCreation@DateInstance@JSC@@IAEXAAVJSGlobalData@2@N@Z > + ?finishCreation@InternalFunction@JSC@@IAEXAAVJSGlobalData@2@PAVJSGlobalObject@2@ABVIdentifier@2@@Z > ?finishCreation@JSArray@JSC@@IAEXAAVJSGlobalData@2@@Z > ?finishCreation@JSArray@JSC@@IAEXAAVJSGlobalData@2@ABVArgList@2@@Z > ?finishCreation@JSFunction@JSC@@IAEXPAVExecState@2@PAVJSGlobalObject@2@HABVIdentifier@2@PAVExecutableBase@2@@Z > ?finishCreation@JSObjectWithGlobalObject@JSC@@IAEXAAVJSGlobalData@2@PAVJSGlobalObject@2@@Z > + ?finishCreation@RegExpObject@JSC@@IAEXPAVJSGlobalObject@2@@Z > + ?finishCreation@StringObject@JSC@@IAEXAAVJSGlobalData@2@PAVJSString@2@@Z > ?focus@Profile@JSC@@QAEXPBVProfileNode@2@@Z Indentation level seems inconsistent here.
Created attachment 106277 [details] Fixing spacing issue
Comment on attachment 106277 [details] Fixing spacing issue Marking cq+ since Mark is not a committer yet.
Comment on attachment 106277 [details] Fixing spacing issue Rejecting attachment 106277 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Source/WebKit2/WebProcess/Plugins/Netscape/JSNPMethod.h Hunk #2 succeeded at 38 with fuzz 2. patching file Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.cpp Hunk #2 FAILED at 68. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.cpp.rej patching file Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/9601140
Created attachment 106517 [details] Rebasing
Comment on attachment 106517 [details] Rebasing rs=me
Comment on attachment 106517 [details] Rebasing Clearing flags on attachment: 106517 Committed r94627: <http://trac.webkit.org/changeset/94627>
All reviewed patches have been landed. Closing bug.
It appears that this patch broke Snow Leopard build: http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Build%29/builds/33559/steps/compile-webkit/logs/stdio
And it broke ecma/Date/15.9.5.js JSC test and fast/js/exception-properties.html layout test on GTK and Qt bots.
SL build was fixed by http://trac.webkit.org/changeset/94632, but tests were still broken, so I had to rollout the original patch with SL buildfix: http://trac.webkit.org/changeset/94644
And it broke SL-WK2 and Qt-WK2 too: http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/builds/14713 http://build.webkit.sed.hu/builders/x86-32%20Linux%20Qt%20Release%20WebKit2/builds/11401
Created attachment 106681 [details] Patch
Comment on attachment 106681 [details] Patch Attachment 106681 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9603986
Created attachment 106757 [details] Patch
Created attachment 106888 [details] Resetting bindings
Comment on attachment 106888 [details] Resetting bindings r=me
Comment on attachment 106888 [details] Resetting bindings Clearing flags on attachment: 106888 Committed r94875: <http://trac.webkit.org/changeset/94875>