RESOLVED FIXED 67399
Web Inspector: XMLHttpRequest console logging messages should link to network panel when possible. 
https://bugs.webkit.org/show_bug.cgi?id=67399
Summary Web Inspector: XMLHttpRequest console logging messages should link to network...
Vsevolod Vlasov
Reported 2011-09-01 07:25:09 PDT
XMLHttpRequest console logging messages should link to network panel when possible.
Attachments
Patch (15.93 KB, patch)
2011-09-01 08:02 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (18.63 KB, patch)
2011-09-01 09:58 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (27.80 KB, patch)
2011-09-21 09:24 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (29.04 KB, patch)
2011-09-21 10:09 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (29.02 KB, patch)
2011-09-22 04:54 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (14.45 KB, patch)
2011-09-22 07:26 PDT, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2011-09-01 08:02:10 PDT
Created attachment 105965 [details] Patch
WebKit Review Bot
Comment 2 2011-09-01 09:45:44 PDT
Comment on attachment 105965 [details] Patch Attachment 105965 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9581324
Vsevolod Vlasov
Comment 3 2011-09-01 09:58:08 PDT
Created attachment 105983 [details] Patch
Yury Semikhatsky
Comment 4 2011-09-05 23:59:37 PDT
Comment on attachment 105983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105983&action=review > Source/WebCore/inspector/front-end/inspector.js:1264 > + if (typeof(lineNumber) !== "undefined") { style: no need for brackets around typeof argument
Vsevolod Vlasov
Comment 5 2011-09-21 09:24:34 PDT
Created attachment 108169 [details] Patch
WebKit Review Bot
Comment 6 2011-09-21 09:33:29 PDT
Comment on attachment 108169 [details] Patch Attachment 108169 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9765816
WebKit Review Bot
Comment 7 2011-09-21 09:54:57 PDT
Comment on attachment 108169 [details] Patch Attachment 108169 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9764829 New failing tests: inspector/protocol/console-agent.html
Vsevolod Vlasov
Comment 8 2011-09-21 10:09:13 PDT
Created attachment 108174 [details] Patch
WebKit Review Bot
Comment 9 2011-09-21 11:23:02 PDT
Comment on attachment 108174 [details] Patch Attachment 108174 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9764868
Vsevolod Vlasov
Comment 10 2011-09-22 04:54:08 PDT
Created attachment 108314 [details] Patch
Pavel Feldman
Comment 11 2011-09-22 05:08:02 PDT
Comment on attachment 108174 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108174&action=review > Source/WebCore/inspector/front-end/ConsoleMessage.js:502 > +WebInspector.ConsoleMessage.NetworkMessageType = { This seems ugly. Sorry for dragging you into it. I'd say that we can dupe messages strings for network and keep them both in front-end and back-end for the sake of the better protocol.
Vsevolod Vlasov
Comment 12 2011-09-22 07:26:13 PDT
Created attachment 108329 [details] Patch
Vsevolod Vlasov
Comment 13 2011-09-26 13:06:10 PDT
Committed r95984: <http://trac.webkit.org/changeset/95984>
Note You need to log in before you can comment on or make changes to this bug.