Bug 67399 - Web Inspector: XMLHttpRequest console logging messages should link to network panel when possible.
Summary: Web Inspector: XMLHttpRequest console logging messages should link to network...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-01 07:25 PDT by Vsevolod Vlasov
Modified: 2011-09-26 13:06 PDT (History)
13 users (show)

See Also:


Attachments
Patch (15.93 KB, patch)
2011-09-01 08:02 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff
Patch (18.63 KB, patch)
2011-09-01 09:58 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff
Patch (27.80 KB, patch)
2011-09-21 09:24 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff
Patch (29.04 KB, patch)
2011-09-21 10:09 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff
Patch (29.02 KB, patch)
2011-09-22 04:54 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff
Patch (14.45 KB, patch)
2011-09-22 07:26 PDT, Vsevolod Vlasov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2011-09-01 07:25:09 PDT
XMLHttpRequest console logging messages should link to network panel when possible.
Comment 1 Vsevolod Vlasov 2011-09-01 08:02:10 PDT
Created attachment 105965 [details]
Patch
Comment 2 WebKit Review Bot 2011-09-01 09:45:44 PDT
Comment on attachment 105965 [details]
Patch

Attachment 105965 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9581324
Comment 3 Vsevolod Vlasov 2011-09-01 09:58:08 PDT
Created attachment 105983 [details]
Patch
Comment 4 Yury Semikhatsky 2011-09-05 23:59:37 PDT
Comment on attachment 105983 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105983&action=review

> Source/WebCore/inspector/front-end/inspector.js:1264
> +        if (typeof(lineNumber) !== "undefined") {

style: no need for brackets around typeof argument
Comment 5 Vsevolod Vlasov 2011-09-21 09:24:34 PDT
Created attachment 108169 [details]
Patch
Comment 6 WebKit Review Bot 2011-09-21 09:33:29 PDT
Comment on attachment 108169 [details]
Patch

Attachment 108169 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9765816
Comment 7 WebKit Review Bot 2011-09-21 09:54:57 PDT
Comment on attachment 108169 [details]
Patch

Attachment 108169 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9764829

New failing tests:
inspector/protocol/console-agent.html
Comment 8 Vsevolod Vlasov 2011-09-21 10:09:13 PDT
Created attachment 108174 [details]
Patch
Comment 9 WebKit Review Bot 2011-09-21 11:23:02 PDT
Comment on attachment 108174 [details]
Patch

Attachment 108174 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9764868
Comment 10 Vsevolod Vlasov 2011-09-22 04:54:08 PDT
Created attachment 108314 [details]
Patch
Comment 11 Pavel Feldman 2011-09-22 05:08:02 PDT
Comment on attachment 108174 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108174&action=review

> Source/WebCore/inspector/front-end/ConsoleMessage.js:502
> +WebInspector.ConsoleMessage.NetworkMessageType = {

This seems ugly. Sorry for dragging you into it. I'd say that we can dupe messages strings for network and keep them both in front-end and back-end for the sake of the better protocol.
Comment 12 Vsevolod Vlasov 2011-09-22 07:26:13 PDT
Created attachment 108329 [details]
Patch
Comment 13 Vsevolod Vlasov 2011-09-26 13:06:10 PDT
Committed r95984: <http://trac.webkit.org/changeset/95984>