[Qt][WK2] fast/loader tests failed after r94178

[Fehér Zsolt]

This tests is:
fast/loader/local-CSS-from-local.html
fast/loader/local-JavaScript-from-local.html
fast/loader/local-image-from-local.html

[Fehér Zsolt]

Tests Skipped in:
http://trac.webkit.org/changeset/94289

[Luciano Wolf]

Created attachment 124004 [details]
Patch

Applying the same fix used for Qt-WebKit1 from bug #67254 [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()

[Simon Hausmann]

Comment on attachment 124004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124004&action=review

> Tools/WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:92
> +    QString localTmpUrl(QLatin1String("file:///tmp/LayoutTests"));

Since this is Qt 5 it's better to write:

QString localTmpUrl(QStringLiteral("..."));

> Tools/WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:93
> +    QString givenUrl(QString(reinterpret_cast<const QChar*>(JSStringGetCharactersPtr(url)), JSStringGetLength(url)));

Why call the QString constructor twice? Can't you simply write:

QString givenUrl(reinterpret_cast..., ...);

[Luciano Wolf]

Created attachment 124146 [details]
Patch

Applying suggested changes to the previous patch. Thanks Simon.

[WebKit Review Bot]

Comment on attachment 124146 [details]
Patch

Clearing flags on attachment: 124146

Committed r106028: <http://trac.webkit.org/changeset/106028>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.