Bug 67380 - [GTK] Generate gobject bindings for Notification and NotificationCenter
Summary: [GTK] Generate gobject bindings for Notification and NotificationCenter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on: 67490
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-01 02:16 PDT by Patrick R. Gansterer
Modified: 2011-09-02 09:53 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.37 KB, patch)
2011-09-01 02:19 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-09-01 02:16:36 PDT
[GTK] Generate gobject bindings for Notification and NotificationCenter
Comment 1 Patrick R. Gansterer 2011-09-01 02:19:34 PDT
Created attachment 105928 [details]
Patch
Comment 2 Philippe Normand 2011-09-02 03:09:06 PDT
Comment on attachment 105928 [details]
Patch

LGTM and GTK EWS didn't complain. Thanks!
Comment 3 WebKit Review Bot 2011-09-02 04:09:56 PDT
Comment on attachment 105928 [details]
Patch

Clearing flags on attachment: 105928

Committed r94404: <http://trac.webkit.org/changeset/94404>
Comment 4 WebKit Review Bot 2011-09-02 04:10:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Xan Lopez 2011-09-02 09:32:51 PDT
This patch is wrong in several ways.

- It's not adding the headers to the Makefile, so the end result is broken.
- You need to reviewers r+ to add new API.
- We don't add new bindings API without a justification of why we would want to do so.
- We are already working on this elsewhere, and this has some problems that we need to discuss without going ahead: https://bugs.webkit.org/show_bug.cgi?id=61140

I'm going to rollout for all those reasons.
Comment 6 Philippe Normand 2011-09-02 09:53:29 PDT
Oh, sorry :( It just seemed like an harmless change, I overlooked the API addition implied by this patch.