Bug 67372 - [chromium] Move ImageBuffer::platformLayer()
Summary: [chromium] Move ImageBuffer::platformLayer()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: noel gordon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-01 00:52 PDT by noel gordon
Modified: 2011-09-01 18:57 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.87 KB, patch)
2011-09-01 01:00 PDT, noel gordon 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description noel gordon 2011-09-01 00:52:25 PDT 
Have some toDataURL() related work upcoming and platformLayer() is sitting right in the
middle of it :)  Hope you don't mind my moving out of the way.
Comment 1 noel gordon 2011-09-01 01:00:06 PDT 
Created attachment 105919 [details]
Patch
Comment 2 noel gordon 2011-09-01 01:27:59 PDT 
And curious, does this routine need a #if USE(ACCELERATED_COMPOSITING) guard?  A cursory look at 
http://trac.webkit.org/changeset/93157/trunk/Source/WebCore/platform/graphics/ImageBuffer.h made
me think so.
Comment 3 Kenneth Russell 2011-09-01 11:45:46 PDT 
Comment on attachment 105919 [details]
Patch

This looks fine.
Comment 4 Kenneth Russell 2011-09-01 11:46:35 PDT 
(In reply to comment #2)
> And curious, does this routine need a #if USE(ACCELERATED_COMPOSITING) guard?  A cursory look at 
> http://trac.webkit.org/changeset/93157/trunk/Source/WebCore/platform/graphics/ImageBuffer.h made
> me think so.

Not sure -- it's been a while since we compiled without that flag so there might be several compilation errors throughout the code base.
Comment 5 WebKit Review Bot 2011-09-01 12:39:24 PDT 
Comment on attachment 105919 [details]
Patch

Clearing flags on attachment: 105919

Committed r94332: <http://trac.webkit.org/changeset/94332>
Comment 6 WebKit Review Bot 2011-09-01 12:39:28 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 noel gordon 2011-09-01 18:57:46 PDT 
(In reply to comment #4)
> Not sure -- it's been a while since we compiled without that flag so there might be several compilation errors throughout the code base.

OK thanks, so long as we know it.