Bug 67362 - Define PTHREAD_KEYS_MAX to fix Android port build
Summary: Define PTHREAD_KEYS_MAX to fix Android port build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 66689
  Show dependency tree / graph
 
Reported: 2011-08-31 23:06 PDT by Hao Zheng
Modified: 2011-09-01 21:28 PDT (History)
5 users (show)

See Also:

Attachments
Proposed patch. (996 bytes, patch)
2011-08-31 23:18 PDT, Hao Zheng 		abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff
Proposed patch 2. (1.19 KB, patch)
2011-09-01 00:07 PDT, Hao Zheng 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hao Zheng 2011-08-31 23:06:04 PDT 
PTHREAD_KEYS_MAX is not defined in bionic, so explicitly define it here.
Comment 1 Hao Zheng 2011-08-31 23:18:31 PDT 
Created attachment 105897 [details]
Proposed patch.
Comment 2 Adam Barth 2011-08-31 23:21:29 PDT 
Comment on attachment 105897 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=105897&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        Define PTHREAD_KEYS_MAX to fix Android port build.
> +        https://bugs.webkit.org/show_bug.cgi?id=67362
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * wtf/ThreadIdentifierDataPthreads.cpp:

It would be good to include the information from the bug about this being a missing feature of bionic in the ChangeLog.
Comment 3 Hao Zheng 2011-09-01 00:07:46 PDT 
Created attachment 105906 [details]
Proposed patch 2.
Comment 4 Hao Zheng 2011-09-01 02:31:31 PDT 
Sorry, one correction: It's not for Android port, which no longer exists. It's for Chromium port for Android.
And one clarification: it's not a build fix for the bot, but it's required when Chromium for Android starts using the code.
Comment 5 WebKit Review Bot 2011-09-01 02:39:53 PDT 
Comment on attachment 105906 [details]
Proposed patch 2.

Clearing flags on attachment: 105906

Committed r94281: <http://trac.webkit.org/changeset/94281>
Comment 6 WebKit Review Bot 2011-09-01 02:39:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Alexey Proskuryakov 2011-09-01 10:18:05 PDT 
Comment on attachment 105906 [details]
Proposed patch 2.

View in context: https://bugs.webkit.org/attachment.cgi?id=105906&action=review

> Source/JavaScriptCore/wtf/ThreadIdentifierDataPthreads.cpp:40
> +// PTHREAD_KEYS_MAX is not defined in bionic, so explicitly define it here.

Are you tracking this as a bug? It would help to have a link to that bug in a comment, so that we would know when it's safe to remove the workaround.
Comment 8 Hao Zheng 2011-09-01 21:28:53 PDT 
See android bug: http://code.google.com/p/android/issues/detail?id=19764 .