Bug 67359 - empty-urls.html seems to have erratic output.
Summary: empty-urls.html seems to have erratic output.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nate Chapin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-31 22:35 PDT by David Levin
Modified: 2011-10-28 09:58 PDT (History)
4 users (show)

See Also:


Attachments
patch (2.34 KB, patch)
2011-09-01 09:49 PDT, Nate Chapin
no flags Details | Formatted Diff | Diff
yet another attempt (6.68 KB, patch)
2011-10-27 16:35 PDT, Nate Chapin
no flags Details | Formatted Diff | Diff
Patch for landing (10.02 KB, patch)
2011-10-28 09:35 PDT, Nate Chapin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2011-08-31 22:35:27 PDT
Full name: http/tests/loading/empty-urls.html

Flakiness examples: 
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Floading%2Fempty-urls.html&showExpectations=true
Comment 1 Nate Chapin 2011-09-01 08:43:24 PDT
The failure I'm seeing on the dashboard appears to be based on whether the load event finishes before notifyDone() is called.  Will try to stabilize that.
Comment 2 Nate Chapin 2011-09-01 09:49:15 PDT
Created attachment 105980 [details]
patch
Comment 3 WebKit Review Bot 2011-09-01 11:36:14 PDT
Comment on attachment 105980 [details]
patch

Clearing flags on attachment: 105980

Committed r94320: <http://trac.webkit.org/changeset/94320>
Comment 4 WebKit Review Bot 2011-09-01 11:36:18 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 David Levin 2011-10-25 18:17:08 PDT
This doesn't appear to have been fixed for two reasons:
1. The expectations file never had this line removed.
2. The test is still flaky: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Floading%2Fempty-urls.html
Comment 6 Nate Chapin 2011-10-27 13:47:28 PDT
(In reply to comment #5)
> This doesn't appear to have been fixed for two reasons:
> 1. The expectations file never had this line removed.
> 2. The test is still flaky: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Floading%2Fempty-urls.html

I'm stumped on how to resolve this.  It's flaky because the order of the frame load callbacks for the main frame (specifically, didFinishLoadForFrame and didHandleOnloadEventsForFrame) is non-deterministic.  I'm not seeing a good way to turn those outputs off, nor how to force the ordering to be deterministic.

Suggestions welcome.
Comment 7 Adam Barth 2011-10-27 13:48:26 PDT
Comment on attachment 105980 [details]
patch

I think you can turn them off by moving the test out of the "loading" directory.
Comment 8 Nate Chapin 2011-10-27 14:26:17 PDT
(In reply to comment #7)
> (From update of attachment 105980 [details])
> I think you can turn them off by moving the test out of the "loading"

....

That did it.  Where on earth is that defined/documented?
Comment 9 Nate Chapin 2011-10-27 16:35:34 PDT
Created attachment 112780 [details]
yet another attempt
Comment 10 David Levin 2011-10-27 16:43:36 PDT
(In reply to comment #9)
> Created an attachment (id=112780) [details]
> yet another attempt

You're going to need to resolve conflicts to get a cq+ that will work.
Comment 11 Nate Chapin 2011-10-28 09:35:25 PDT
Created attachment 112875 [details]
Patch for landing
Comment 12 WebKit Review Bot 2011-10-28 09:58:50 PDT
Comment on attachment 112875 [details]
Patch for landing

Clearing flags on attachment: 112875

Committed r98732: <http://trac.webkit.org/changeset/98732>
Comment 13 WebKit Review Bot 2011-10-28 09:58:55 PDT
All reviewed patches have been landed.  Closing bug.